`deer` implement `Deserialize` for built-in types (Part 1) #1516

indietyp · 2022-11-28T10:58:38Z

🌟 What is the purpose of this PR?

This implements Deserialize for a select built-in types.

🔗 Related links

🚫 Blocked by

📹 Demo

vercel · 2022-12-06T15:50:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Updated
hash	🔄 Building (Inspect)	Jan 6, 2023 at 7:11PM (UTC)
hash-design-system	🔄 Building (Inspect)	Jan 6, 2023 at 7:11PM (UTC)
hashdotdev	🔄 Building (Inspect)	Jan 6, 2023 at 7:11PM (UTC)

codecov · 2022-12-06T15:55:34Z

Codecov Report

Merging #1516 (28942ce) into main (e155952) will increase coverage by 1.94%.
The diff coverage is 67.10%.

@@            Coverage Diff             @@
##             main    #1516      +/-   ##
==========================================
+ Coverage   55.10%   57.05%   +1.94%     
==========================================
  Files         251      260       +9     
  Lines       18076    18371     +295     
  Branches      421      421              
==========================================
+ Hits         9961    10481     +520     
+ Misses       8110     7885     -225     
  Partials        5        5

Flag	Coverage Δ
backend-integration-tests	`3.66% <ø> (ø)`
deer	`65.06% <67.10%> (+10.78%)`	⬆️
unit-tests	`1.49% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/libs/deer/desert/src/lib.rs	`100.00% <ø> (ø)`
packages/libs/deer/src/impls/core/atomic.rs	`0.00% <0.00%> (ø)`
packages/libs/deer/src/number.rs	`43.52% <12.50%> (+43.52%)`	⬆️
packages/libs/deer/src/lib.rs	`37.14% <35.38%> (+18.24%)`	⬆️
packages/libs/deer/src/impls/core/string.rs	`50.00% <50.00%> (ø)`
packages/libs/deer/src/impls/core/bool.rs	`53.84% <53.84%> (ø)`
packages/libs/deer/src/impls/core/floating.rs	`53.84% <53.84%> (ø)`
packages/libs/deer/src/impls/core/unit.rs	`53.84% <53.84%> (ø)`
packages/libs/deer/src/schema.rs	`90.90% <57.14%> (+9.99%)`	⬆️
packages/libs/deer/src/impls/core/array.rs	`74.03% <74.03%> (ø)`
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

thehabbos007

Looks great, Bilal! I left some comments. The error messages/structure and general composibility is turning out to look very neat!

packages/libs/deer/Cargo.toml

thehabbos007 · 2023-01-16T17:02:47Z

packages/libs/deer/rust-toolchain.toml

@@ -1,3 +1,3 @@
 [toolchain]
 channel = "nightly-2022-11-14"


Slightly unrelated to PR, but do we want to bump the channel soon?

thehabbos007 · 2023-01-16T17:07:03Z

packages/libs/deer/desert/src/assert.rs

    T: Deserialize<'de> + Debug,
+    Value: PartialEq<E>,


I haven't seen this sort of syntax before. Is Value the serde_json Value Enum? Why do we need to set a specific bound for it to be PartialEq here?

Thanks! I need to change this, I initially added this for better diagnostics, but similar fails to display a diff between two different types properly. I need to change this so that the error is "casted" to the error enum instead. The bound is here because

assert_eq! requires that the LHS implements PartialEq. Therefore the bound was needed, and not the other way around.

reworked in af34989

Looks great!

packages/libs/deer/desert/src/token.rs

packages/libs/deer/src/error/type.rs

packages/libs/deer/src/impls/core/array.rs

packages/libs/deer/src/impls/core/mod.rs

packages/libs/deer/tests/test_impls_core_non_zero.rs

Co-authored-by: Ahmad Sattar <thehabbos007@gmail.com>

…er/stdlib # Conflicts: # packages/libs/deer/desert/src/token.rs

thehabbos007

Happy for this to merge. The remaining open comment is just a follow-up and does not blocking merging :)

github-actions bot added the area/libs > deer Affects the `deer` crate (library) label Nov 28, 2022

indietyp mentioned this pull request Nov 30, 2022

deer-json initial implementation #1478

Merged

2 tasks

indietyp changed the title ~~deer implement Deserializefor built-in types~~ deer implement Deserialize for built-in types Nov 30, 2022

vercel bot deployed to Preview – hash December 6, 2022 15:58 View deployment

vercel bot deployed to Preview – hashdotdev December 6, 2022 16:04 View deployment

vercel bot deployed to Preview – hash December 6, 2022 18:40 View deployment

vercel bot deployed to Preview – hash December 6, 2022 18:44 View deployment

indietyp mentioned this pull request Dec 10, 2022

deer housekeeping #1645

Merged

vercel bot deployed to Preview – hash-design-system December 20, 2022 10:37 View deployment

vercel bot deployed to Preview – hash December 20, 2022 10:38 View deployment

vercel bot had a problem deploying to Preview – hashdotdev December 20, 2022 10:41 Failure

vercel bot deployed to Preview – hash December 20, 2022 11:07 View deployment

indietyp mentioned this pull request Dec 20, 2022

GEN-160: deer type implementation #1700

Open

vercel bot deployed to Preview – hash December 20, 2022 11:26 View deployment

indietyp added 14 commits December 20, 2022 12:30

init: framework crate

ab07079

feat: token + deserialize (initial)

225619f

feat: implement ArrayAccess

03eb3bf

feat: ObjectAccess skeleton

cfa0506

feat: peek ignore trivia

b09de56

drive-by: move SetBoundedError into deer

74d9776

feat: start error recovery

5ac60a0

todo: oversight

d9e4806

feat: introduction of trivia tape

01f0fc6

feat: Cow equivalent for Trivia to avoid allocation

e976b35

feat: rework .end for array

acd1909

feat: ObjectLengthError

0c2e0f0

feat: reorganize code

6f0c870

feat: fix compiler error

b2b29f4

indietyp marked this pull request as ready for review January 11, 2023 15:19

Merge branch 'main' into bm/deer/stdlib

14b8fce

indietyp changed the title ~~deer implement Deserialize for built-in types~~ deer implement Deserialize for built-in types (Part 1) Jan 11, 2023

vercel bot deployed to Preview – hash January 11, 2023 15:39 View deployment

indietyp added 4 commits January 11, 2023 16:45

fix: atomic presence on machines

3bd3ad0

feat: impl for AtomicBool

d9e63ba

fix: clippy

b291c8b

fix: clippy?

acbce74

vercel bot deployed to Preview – hash January 11, 2023 16:03 View deployment

thehabbos007 reviewed Jan 16, 2023

View reviewed changes

chore: remove redundant comment

0a2954a

vercel bot deployed to Preview – hash January 16, 2023 18:01 View deployment

indietyp and others added 3 commits January 16, 2023 19:15

Update packages/libs/deer/desert/src/token.rs

6f6abd0

Co-authored-by: Ahmad Sattar <thehabbos007@gmail.com>

chore: fix docs

4835afc

Merge branch 'bm/deer/stdlib' of github.com:hashintel/hash into bm/de…

e3e6b8d

…er/stdlib # Conflicts: # packages/libs/deer/desert/src/token.rs

vercel bot deployed to Preview – hash January 16, 2023 18:31 View deployment

indietyp added 2 commits January 16, 2023 19:42

feat: move Error into desert and use for token assertion

af34989

Merge branch 'main' into bm/deer/stdlib

273f5c4

indietyp requested a review from thehabbos007 January 16, 2023 18:44

vercel bot deployed to Preview – hash January 16, 2023 18:54 View deployment

vercel bot deployed to Preview – hashdotdev January 16, 2023 18:56 View deployment

vercel bot deployed to Preview – hash-design-system January 16, 2023 19:15 View deployment

thehabbos007 approved these changes Jan 17, 2023

View reviewed changes

Merge branch 'main' into bm/deer/stdlib

d264111

indietyp enabled auto-merge (squash) January 17, 2023 09:33

vercel bot deployed to Preview – hash January 17, 2023 09:42 View deployment

Merge branch 'main' into bm/deer/stdlib

28942ce

vercel bot deployed to Preview – hash January 17, 2023 09:54 View deployment

indietyp merged commit ab77a25 into main Jan 17, 2023

indietyp deleted the bm/deer/stdlib branch January 17, 2023 09:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`deer` implement `Deserialize` for built-in types (Part 1) #1516

`deer` implement `Deserialize` for built-in types (Part 1) #1516

indietyp commented Nov 28, 2022 •

edited

Loading

vercel bot commented Dec 6, 2022 •

edited

Loading

codecov bot commented Dec 6, 2022 •

edited

Loading

thehabbos007 left a comment

thehabbos007 Jan 16, 2023

thehabbos007 Jan 16, 2023

indietyp Jan 16, 2023

indietyp Jan 16, 2023

thehabbos007 Jan 17, 2023

thehabbos007 left a comment

deer implement Deserialize for built-in types (Part 1) #1516

deer implement Deserialize for built-in types (Part 1) #1516

Conversation

indietyp commented Nov 28, 2022 • edited Loading

🌟 What is the purpose of this PR?

🔗 Related links

🚫 Blocked by

📹 Demo

vercel bot commented Dec 6, 2022 • edited Loading

codecov bot commented Dec 6, 2022 • edited Loading

Codecov Report

thehabbos007 left a comment

Choose a reason for hiding this comment

thehabbos007 Jan 16, 2023

Choose a reason for hiding this comment

thehabbos007 Jan 16, 2023

Choose a reason for hiding this comment

indietyp Jan 16, 2023

Choose a reason for hiding this comment

indietyp Jan 16, 2023

Choose a reason for hiding this comment

thehabbos007 Jan 17, 2023

Choose a reason for hiding this comment

thehabbos007 left a comment

Choose a reason for hiding this comment

`deer` implement `Deserialize` for built-in types (Part 1) #1516

`deer` implement `Deserialize` for built-in types (Part 1) #1516

indietyp commented Nov 28, 2022 •

edited

Loading

vercel bot commented Dec 6, 2022 •

edited

Loading

codecov bot commented Dec 6, 2022 •

edited

Loading