CI: switch from quickinstall to install-action
#2021
Conversation
github-actions
bot
added
the
area/infra
|
Nice side-effect: install tools now only takes 14s instead of 51s (for error-stack). |
There was a problem hiding this comment.
Worth a try 🎉
However, do we want to try out the install action instead? It fallsback to cargo-bininstall.
Nice side-effect: install tools now only takes 14s instead of 51s (for error-stack).
Well, I doubt, that cargo install bininstall is faster than cargo install quickinstall
It isn't but we're circumventing |
indietyp
changed the title
install-action
|
|
(This does not yet work, need to wait for upstream)
|
Same here, but I need this to be ready (not draft), as otherwise, I am unable to run our CI suite |
|
Triage: Upstream issue is resolved but no release was filed yet. |
|
Triage: new release has been cut upstream, will run CI a couple of time to ensure no regressions. |
|
CI ran five times with the new version, each time with ~14 tool installations, therefore I think it is safe to say the previous bug has been fixed. |
| cargo quickinstall cargo-hack --version 0.5.26 || cargo install --version 0.5.26 cargo-hack | ||
| uses: taiki-e/install-action@v2 | ||
| with: | ||
| tool: cargo-make@0.36.3,cargo-hack@0.5.26 |
There was a problem hiding this comment.
Too bad it requires a comma-separated list, an array would be easier to read.
This reverts commit d73b75a
🌟 What is the purpose of this PR?
Currently, we use
quickinstallto install all dependencies required, but (especially the lint job) jobs have been failing spuriously. This tries to fix the issue by installing the big brother ofcargo-quickinstall:cargo-binstall, which is from the same organization, but more actively maintained and active.binstallfalls back to thequickinstallrepo of precompiled binaries if available.🔗 Related links
📹 Demo