Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deer: implement Deserialize for core::option #2383

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Conversation

indietyp
Copy link
Member

🌟 What is the purpose of this PR?

Implements Deserialize for:

  • core::option::Option

Taken from #1875

❗ Known Limitations

The current schema is problematic; it cannot accurately represent oneOf, and two different proposals to solve this are available as a prototype.

🔗 Related links

🔍 Has this modified a publishable library?

This PR:

  • modifies an npm-publishable library and I have added a changeset file(s)
  • modifies a Cargo-publishable library and I have amended the version
  • modifies a Cargo-publishable library, but it is not yet ready to publish
  • modifies a block that will need publishing via GitHub action once merged
  • does not modify any publishable blocks or libraries
  • I am unsure / need advice

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #2383 (1c29b14) into main (720c4dc) will increase coverage by 0.04%.
The diff coverage is 53.57%.

@@            Coverage Diff             @@
##             main    #2383      +/-   ##
==========================================
+ Coverage   60.69%   60.73%   +0.04%     
==========================================
  Files         313      314       +1     
  Lines       24199    24227      +28     
  Branches      421      421              
==========================================
+ Hits        14687    14714      +27     
- Misses       9507     9508       +1     
  Partials        5        5              
Flag Coverage Δ
backend-integration-tests 3.66% <ø> (ø)
deer 69.59% <53.57%> (+0.20%) ⬆️
unit-tests 1.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/deer/src/impls/core/option.rs 53.57% <53.57%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@indietyp indietyp added this pull request to the merge queue Apr 13, 2023
Merged via the queue into main with commit cb6d9f7 Apr 13, 2023
@indietyp indietyp deleted the bm/deer/core-option branch April 13, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs > deer Affects the `deer` crate (library)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants