deer: implement Deserialize for core::time
#2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2390 +/- ##
==========================================
+ Coverage 56.77% 60.90% +4.13%
==========================================
Files 337 318 -19
Lines 26015 24233 -1782
Branches 421 421
==========================================
- Hits 14769 14760 -9
+ Misses 11241 9468 -1773
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 34 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| let input = value.as_secs_f64(); | ||
|
|
||
| assert_tokens_with_assertion(|received: Duration| { | ||
| assert_relative_eq!(received.as_secs_f64(), value.as_secs_f64()); |
There was a problem hiding this comment.
Is approx used in future implementations? Or can we simply do a - b < f64:EPSILON for f64 comparisons?
There was a problem hiding this comment.
nope not at all, we can indeed just use a - b < f64:EPSILON. Good catch!
thehabbos007
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Implements
Deserializefor:core::time::Duration(taken fromdeerimplementDeserializefor built-in types (Part 2) #1875, same format as serde)Based on #2376, due to new assertion function used for relative equality.
🔗 Related links
deerimplementDeserializefor built-in types (Part 2) #1875deertype implementation #1700🔍 Has this modified a publishable library?
This PR: