deer: implement Deserialize for tuples
#2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2418 +/- ##
==========================================
+ Coverage 56.32% 57.00% +0.68%
==========================================
Files 338 342 +4
Lines 26248 26085 -163
Branches 384 421 +37
==========================================
+ Hits 14784 14871 +87
+ Misses 11463 11209 -254
- Partials 1 5 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 33 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6 tasks
thehabbos007
approved these changes
Apr 28, 2023
| } | ||
|
|
||
| #[rustfmt::skip] | ||
| macro_rules! all_the_tuples { |
There was a problem hiding this comment.
tuples all the way down
Comment on lines
+45
to
+47
| Schema::new("array") | ||
| .with("prefixItems", [$(doc.add::<$elem>()),*]) | ||
| .with("items", false) |
There was a problem hiding this comment.
Nice to see this conform to the newest draft 👍
CiaranMn
pushed a commit
that referenced
this pull request
Apr 28, 2023
* feat: glue helper trait `TupleExt` * feat: take code from #1875 and fix * test: array impl * fix: miri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Implements
Deserializefor tuples of up to 16 items (likeaxum), originally taken from #1875, because there is no variadic support for tuples just yet (or even ever? D:) this is quite macro-heavy code.Stats:
serde: up to 16 elementsproptest: up to 9 elementsbuiltin: up to 12 elements forPartialEq,Eq,PartialOrd,Debug,Default,Hash, other built-in traits are infinite.deer: up to 16 elementsaxum: up to 16 elementsTo facilitate proper error handling a temporary trait
TupleExthas been added, once #2377 has been resolved a more long-term solution will be implemented.🔗 Related links
deertype implementation #1700deerimplementDeserializefor built-in types (Part 2) #1875🚀 Has this modified a publishable library?
This PR: