Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempus-746 policy based pagination #781

Merged
merged 7 commits into from
Oct 11, 2018

Conversation

akshaymhetre
Copy link
Contributor

Thank you for submitting a contribution to Tempus.

In order to streamline the review of the contribution please
ensure the following steps have been taken:

For all changes:

  • Is there a Waffle ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with Tempus-XXXX where XXXX is the waffle number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically dev)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root Tempus folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • Have you added documentation for any UI or API related changes to the /docs folder

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@akshaymhetre akshaymhetre force-pushed the Tempus-746-policy-based-pagination branch 2 times, most recently from ee454d2 to 9e4f921 Compare October 10, 2018 10:25
@akshaymhetre akshaymhetre force-pushed the Tempus-746-policy-based-pagination branch from 9e4f921 to afc059d Compare October 10, 2018 13:26
@akshaymhetre akshaymhetre merged commit 8fcf72b into dev Oct 11, 2018
@akshaymhetre akshaymhetre deleted the Tempus-746-policy-based-pagination branch October 11, 2018 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant