Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obsolete deno import since Deno v0.3.3 #4

Merged
merged 1 commit into from May 23, 2019
Merged

Fix obsolete deno import since Deno v0.3.3 #4

merged 1 commit into from May 23, 2019

Conversation

sdimkov
Copy link
Contributor

@sdimkov sdimkov commented May 22, 2019

There has been a breaking API change in Deno v0.3.3 that also breaks this module. The import of "deno" module got replaced with a global Deno variable.

The "deno" module removal PR: denoland/deno#1895
Release notes of v0.3.3: denoland/deno@3dbb06e#diff-30ebd105aef11de730b7b473a247e99bR16

Please make sure to release this fix in a major new version (v1.1.0) as the fix itself is a breaking change for people running deno@0.3.2 or older.

There has been a breaking API change in Deno v.0.3.3 that also breaks
this module. The import of "deno" module got replaced with a global Deno
variable.

The "deno" module removal PR: denoland/deno#1895
Release notes of v.0.3.3: denoland/deno@3dbb06e#diff-30ebd105aef11de730b7b473a247e99bR16
@hashrock hashrock merged commit 09c6c59 into hashrock:master May 23, 2019
@hashrock
Copy link
Owner

Thank you! 👍
I'll release this as v1.1.0 later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants