WIP: Add SSL integration to apache2 configuration #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinduerhager
changed the title
|
PR was based on master, will do a new one, based on newest dev changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
i extended the
000-default.confwith a simple ssl configuration.Currently you would have to add a
cert.pemandcert-key.pemto.devcontainer/ssl/.You can do this by running mkcert like this:
Is the apache config in
.devcontainer/sites-enabled/meant to be configured by the user? If so, then i guess #960 is fixed as well? :)It does run without problems in the devcontainer.