first pass at cleaning out bch related code #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
An easy loose end to fix is getting rid of |
Good catch. I knew I was gonna miss something cause I didn't comb through all of the code scrutinizing things that don't exist in BTC. I'll remove that here. |
|
all comments addressed |
ProofOfKeags
force-pushed
the
feature/bch-purge
branch
from
7cb99b1
to
2aef98e
Compare
- reset version - reset changelog - remove CashAddr refs from Haddocks, README, etc. - remove all references to Bitcoin Cash / BCH - remove sighash forkid - remove tests with forkid - fourmolu for formatting
GambolingPangolin
force-pushed
the
feature/bch-purge
branch
from
d8e56c4
to
543ee7c
Compare
GambolingPangolin
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR addresses #1
It seems like there may be more things to do related to pulling out BCH related opcodes out of the script interpretation, however, iirc we may be moving the script interpreter out of the package altogether.