Split test and bench out to separate packages #43
Conversation
wraithm
force-pushed
the
split-test-bench-pkgs
branch
from
a80b198
to
f364e8b
Compare
| @@ -47,26 +44,6 @@ dependencies: | |||
| - vector >= 0.12.1.2 | |||
| library: | |||
| source-dirs: src | |||
| other-modules: Bitcoin.Keys.Extended.Internal | |||
There was a problem hiding this comment.
This is maybe a questionable thing, but tbh, I really dislike other-modules as a thing. Like, what if I want the fingerprint's Word32 or whatever. Just lemme do it.
There was a problem hiding this comment.
I do not like representing Fingerprint as a Word32. How about we just change it to SizedByteArray 4 ByteString? Then I would be more comfortable exposing Fingerprint internals, and maybe getting rid of Bitcoin.Keys.Extended.Internal.
There was a problem hiding this comment.
IMHO, that sounds out of scope for this changeset, but certainly an interesting thought.
There was a problem hiding this comment.
Agreed different changeset. I think exposing Internal modules is common practice in our ecosystem. People know the footguns they entail, let's just expose it.
wraithm
force-pushed
the
split-test-bench-pkgs
branch
from
f364e8b
to
7af814e
Compare
|
The packaging is not very clear from the directory structure. How about reorganizing the code so that there are three folders, each of which contains a package?:
In addition, we can keep |
I'm not opposed to that at all. @ProofOfKeags, what do you think? |
|
100% onboard with that folder structure. |
|
After reviewing as well I'm fine to merge this after exposing internal modules and reorganizing the directories to be more intuitive. |
wraithm
force-pushed
the
split-test-bench-pkgs
branch
from
7af814e
to
df97989
Compare
wraithm
force-pushed
the
split-test-bench-pkgs
branch
from
df97989
to
e43ad04
Compare
|
@ProofOfKeags @GambolingPangolin This is ready for review. |
#42