Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with ghc-7.10 #189

Merged
merged 5 commits into from Jun 2, 2015
Merged

Add compatibility with ghc-7.10 #189

merged 5 commits into from Jun 2, 2015

Conversation

qnikst
Copy link
Contributor

@qnikst qnikst commented Mar 18, 2015

No description provided.

@qnikst
Copy link
Contributor Author

qnikst commented Mar 18, 2015

This PR depends on:

(under review) haskell-distributed/distributed-static#4
(merged, not published) haskell-distributed/rank1dynamic#9
(merged, not published) haskell-distributed/network-transport-tcp#9
(merged, not published) haskell-distributed/network-transport#8

@qnikst
Copy link
Contributor Author

qnikst commented Apr 1, 2015

I have splitted commits into small one and verified build on 7.8 and 7.10

@facundominguez
Copy link
Contributor

Building with ghc-7.4 is failing for some reason.

@@ -137,7 +137,7 @@ import GHC.Generics
newtype NodeId = NodeId { nodeAddress :: NT.EndPointAddress }
deriving (Eq, Ord, Typeable, Data, Generic)
instance Binary NodeId where
instance NFData NodeId
instance NFData NodeId where rnf (NodeId a) = rnf a `seq` ()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should depend on deepseq>=1.4 and drop the where rnf (NodeId a) = rnf a seq ().

http://hackage.haskell.org/package/deepseq-1.4.1.1/docs/Control-DeepSeq.html#t:NFData

Unless I'm misunderstanding the point of this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 possibilities, use generic deriving on >deepseq-1.4 and write instances manually on previous versions, or write instances manually everywhere. I find latter approach more straightforward as former implies latter under if-condition.

@qnikst
Copy link
Contributor Author

qnikst commented Apr 2, 2015

I fixed NFData instance for LazyByteString argument.

@hyperthunk
Copy link
Member

Can't build this right now and travis is failing. Can anyone confirm it had been fixed for 7.4?

@qnikst
Copy link
Contributor Author

qnikst commented Apr 13, 2015

I see "all is well" in travis report:

https://travis-ci.org/haskell-distributed/distributed-process/builds/57053812

@hyperthunk you can run rebuild in top right corner (near settings).

@hyperthunk
Copy link
Member

Yes will do, I've been away for a month so I'm just catching up again.

@isaiah
Copy link

isaiah commented May 22, 2015

Compiling failed on 7.10.1

src/Control/Distributed/Process/Internal/Types.hs:141:47:
    No instance for (NFData NT.EndPointAddress)
      arising from a use of ‘rnf’
    In the first argument of ‘seq’, namely ‘rnf a’
    In the expression: rnf a `seq` ()
    In an equation for ‘rnf’: rnf (NodeId a) = rnf a `seq` ()
cabal: Error: some packages failed to install:
distributed-process-0.5.3 failed during the building phase. The exception was:
ExitFailure 1

@qnikst
Copy link
Contributor Author

qnikst commented May 22, 2015

@isaiah have you used patched version of network-transport? Almost all parts of distributed-process stack have changes. But I hope we will get over this situation soon.

@isaiah
Copy link

isaiah commented May 22, 2015

@qnikst Yes, install network-transport from master does fix the problem. Thanks.

@qnikst
Copy link
Contributor Author

qnikst commented Jun 2, 2015

This one works good for several people on the zurihack, and passes tests, so I'm going to merge this one.

qnikst added a commit that referenced this pull request Jun 2, 2015
Add compatibility with ghc-7.10
@qnikst qnikst merged commit 3606f3d into haskell-distributed:master Jun 2, 2015
@qnikst qnikst deleted the ghc-7.10 branch June 2, 2015 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants