Implement the Webhooks API #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| data RepoWebhook = RepoWebhook { | ||
| repoWebhookUrl :: String | ||
| ,repoWebhookTestUrl :: String | ||
| ,repoWebhookId :: Int |
|
@maxpow4h: Here it goes, I made all the changes you mentioned. Cheers |
|
@nataren Great work! Looks all good to me. I will move some of my code over to that API when I'm working on that next. |
|
Thanks a lot @maxpow4h 👍 @jwiegley I think this puppy is ready to roll in. Thanks. |
|
@nataren Thank you! |
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone. I am submitting this pull request for overall code review, I tried to follow the guidelines as much as possible but please feel free to comment on the code so that its quality improves, in particular for example: