Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails with Cabal 2.4 #15

Closed
jtojnar opened this issue Mar 1, 2019 · 1 comment · Fixed by #18
Closed

Build fails with Cabal 2.4 #15

jtojnar opened this issue Mar 1, 2019 · 1 comment · Fixed by #18

Comments

@jtojnar
Copy link
Contributor

jtojnar commented Mar 1, 2019 •
edited
Loading

matchFileGlob was removed in 2.4 (haskell/cabal#5284) and Distribution.Simple.Glob.matchDirFileGlob with widely different type is supposed to be used instead.

I am not really sure where are we supposed to get the PackageDescription argument value. Perhaps something like https://github.com/google/proto-lens/pull/242/files#diff-4fe9daabe5a3a972435eb21087de0259R183 could work.
@jtojnar jtojnar mentioned this issue Mar 2, 2019
Closed
@jtojnar jtojnar mentioned this issue Mar 14, 2019
Merged
4 tasks
jtojnar added a commit to jtojnar/hgettext that referenced this issue Mar 14, 2019
@jtojnar
Fix build with cabal-2.4
e930c5d 
haskell-hvr#15
@jtojnar jtojnar mentioned this issue Mar 14, 2019
Closed
@ag-eitilt
Copy link

Once one fix or another for this is finalized, this issue is also blocking bumps to GHC 8.8/base ==4.13.* and containers ==0.6.*; it'll probably be a good idea to see if the code builds with those versions afterward and adapt the bounds appropriately.

avdv added a commit to avdv/hgettext that referenced this issue Jan 11, 2022
@avdv
Fix build with Cabal >= 2.4
e580db9 
Fixes haskell-hvr#15
@avdv avdv mentioned this issue Jan 11, 2022
Merged
andreasabel pushed a commit to avdv/hgettext that referenced this issue Sep 4, 2022
@avdv @andreasabel
Fix build with Cabal >= 2.4
1d1a7ff 
Fixes haskell-hvr#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build with Cabal >= 2.4 avdv/hgettext
wip: Fix build with cabal-2.4 jtojnar/hgettext
2 participants
@jtojnar @ag-eitilt