Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language-glsl doesn't support ghc 8.4 #162

Closed
cartazio opened this issue Jun 8, 2018 · 5 comments
Closed

language-glsl doesn't support ghc 8.4 #162

cartazio opened this issue Jun 8, 2018 · 5 comments

Comments

@cartazio
Copy link
Member

cartazio commented Jun 8, 2018

noteed/language-glsl#18
encoutered in the course of fixing up concat
compiling-to-categories/concat#37 (comment)

@cartazio
Copy link
Member Author

cartazio commented Jun 8, 2018

also matrix doesn't do any ghc 8.4 stuff yet :( https://matrix.hackage.haskell.org/package/language-glsl

@gwils
Copy link
Contributor

gwils commented Jun 11, 2018

It's a shame matrix doesn't do GHC 8.4. I use Oleg's trustee tool locally. While developing my own libraries, I use it every day to make sure my commits don't break the older GHC's I support.

At the time of writing, language-glsl gives the following matrix:

                      8.4.1  8.2.2  8.0.2  7.10.3  7.8.4  7.6.3  7.4.2  7.2.2  7.0.4
language-glsl-0.2.1/  FAIL   OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.2.0/  FAIL   OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.1.1/  FAIL   FAIL   FAIL   FAIL    OK     OK     OK     OK     OK   
language-glsl-0.1.0/  FAIL   FAIL   FAIL   FAIL    OK     OK     OK     OK     OK   
language-glsl-0.0.2/  FAIL   FAIL   FAIL   FAIL    OK     OK     OK     OK     OK   
language-glsl-0.0.1/  FAIL   FAIL   FAIL   FAIL    OK     OK     OK     OK     OK   
language-glsl-0.0.0/  FAIL   FAIL   FAIL   FAIL    OK     OK     OK     OK     OK   

@gwils
Copy link
Contributor

gwils commented Jun 11, 2018

I have made revisions to language-glsl so now we get

                      8.4.1  8.2.2  8.0.2  7.10.3  7.8.4  7.6.3  7.4.2  7.2.2  7.0.4
language-glsl-0.2.1/  NO-IP  OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.2.0/  NO-IP  OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.1.1/  DEP    OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.1.0/  DEP    OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.0.2/  DEP    OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.0.1/  DEP    OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.0.0/  DEP    OK     OK     OK      OK     OK     OK     OK     OK   

@gwils
Copy link
Contributor

gwils commented Jun 11, 2018

... and now with some revisions to pretty:

                      8.4.1  8.2.2  8.0.2  7.10.3  7.8.4  7.6.3  7.4.2  7.2.2  7.0.4
language-glsl-0.2.1/  NO-IP  OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.2.0/  NO-IP  OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.1.1/  NO-IP  OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.1.0/  NO-IP  OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.0.2/  NO-IP  OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.0.1/  NO-IP  OK     OK     OK      OK     OK     OK     OK     OK   
language-glsl-0.0.0/  NO-IP  OK     OK     OK      OK     OK     OK     OK     OK   

Obviously this doesn't solve your actual problem, but at least you won't get bad build plans anymore.

Edit: I have emailed the maintainer to inform them of my revisions, and pointed them to the open pull request for 8.4 support at noteed/language-glsl#17

@phadej
Copy link
Member

phadej commented Sep 25, 2018

@phadej phadej closed this as completed Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants