Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basement does not build under GHC 9.0, PRs with fixes are ignored #284

Closed
ethercrow opened this issue Nov 18, 2020 · 11 comments
Closed

basement does not build under GHC 9.0, PRs with fixes are ignored #284

ethercrow opened this issue Nov 18, 2020 · 11 comments

Comments

@ethercrow
Copy link

ethercrow commented Nov 18, 2020

basement and foundation libraries have quite many reverse dependencies, e.g. via cryptonite and http-client-tls or gauge. However, they seem abandoned, there was only one commit in 2020, PRs and issues are ignored.

PRs with fixes for GHC 9.0:
haskell-foundation/foundation#540 by @utdemir
haskell-foundation/foundation#537 by @sgraf812
haskell-foundation/foundation#535 by @andrewthad

@sgraf812
Copy link

Summoning the owner @vincenthz to be part of the discussion

@phadej
Copy link
Member

phadej commented Nov 19, 2020

Is GHC-9.0 released already?

@expipiplus1
Copy link

Might be worth pinging all the people on this page https://github.com/haskell-foundation

@expipiplus1
Copy link

I emailed @vincenthz about this about a week ago and didn't get a reply.

@Bodigrim
Copy link

(Could this be a lesson to learn about custom preludes?..)

@vincenthz
Copy link

PR and issues on unreleased ghc is not my concerns anymore, this will wait until I can get 9.0 on my system (apparently 9.0 release today ..).

@Bodigrim what about a lesson for ghc in not breaking core APIs gratuitously (even "internal APIs") ?

@bergmark
Copy link
Member

bergmark commented Feb 16, 2021

I think it's fair if maintainers want to wait with releases until a new GHC ships. Since this requires code changes outside of revisions I don't think it would be appropriate for us trustees to go against the maintainers wishes and perform a non-maintainer upload.

@bergmark
Copy link
Member

I'm cleaning up the issue tracker a bit so I'll close this nothing that GHC 9 is out now, and hoping this will get sorted without trustee involvement.

@mightybyte
Copy link

FWIW, I agree with @vincenthz. It's unreasonable to expect maintainers to make changes to their packages to accommodate unreleased GHC versions and not something that trustees should deal with. If you want to live on the bleeding edge, you're gonna have to put in some work to do so.

@ethercrow
Copy link
Author

ethercrow commented Feb 16, 2021

FWIW, I agree with @vincenthz. It's unreasonable to expect maintainers to make changes to their packages to accommodate unreleased GHC versions and not something that trustees should deal with. If you want to live on the bleeding edge, you're gonna have to put in some work to do so.

I created this issue because the bleeding edge people have already done most of the work in those PRs and there was not even an acknowledgement. Contrast it with the situation in hashable: haskell-unordered-containers/hashable#189 (comment). A maintainer said that he would look at it when GHC 9.0 is closer to release, it was completely fine.

@bergmark
Copy link
Member

@ethercrow I don't think it's fair to expect a maintainer to respond to every issue filed, what you should expect is what is available at https://github.com/haskell-foundation/foundation/blob/master/LICENSE, everything else is gravy.

This probably sounds rude, but that's not my intention! Vincent has done tons of work for the community and anyone using his libraries ought to be thankful. At least that's what I think.

if we turn complaints into cheers I think we will have a much better outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants