GHC 9 compatibility fixes #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use 'Data.Kind.Type' instead of '*'. Using '*' in that position requires `StarIsType` language extension in GHC 9. * Import `unsafeCoerce#` from `GHC.Exts` (https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.0#base-415) * Relax some upper bounds.
|
Thanks!
I'll revisit this PR once the new major GHC 9.0 release enters its final candidate release phase.
|
|
See #188. This is "lazy" approach, just bumping |
Cool. GHC 9.0.1-rc1 is now out, so perhaps this is the right time to merge this PR? |
2 tasks
|
GHC 9 is out |
|
I'll take a look shortly. I'll look around at other issues as well and will make a release ASAP. Thank you for your patience. |
|
I made few things differently in #195. Thanks for the base work anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StarIsTypelanguage extension in GHC 9.unsafeCoerce#fromGHC.Exts(https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.0#base-415)GHC 9 also comes with
ghc-bignumlibrary which should be preferred overinteger-gmp. However since it also provides a compatibility shim forinteger-gmp, so this PR doesn't change that. It would be good to address #188 at one point.I tried to make it backwards-compatible, however; I only tested this PR on GHC HEAD, so I'm hoping for CI to test the older versions.