Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #84

Merged
merged 2 commits into from
Dec 13, 2020
Merged

Fix #84

merged 2 commits into from
Dec 13, 2020

Conversation

Anton-Latukha
Copy link
Contributor

In decodeBase16: Base16.decode (T.encodeUtf8 t) returns Either String Bytestring and patternmatch was (x, "").

@Anton-Latukha Anton-Latukha mentioned this pull request Dec 13, 2020
Merged
sorki
sorki approved these changes Dec 13, 2020
View reviewed changes
Copy link
Member

@sorki sorki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Error messages were added on purpose and you could possibly use bimap to preserve that but since error handling is far from ideal anyway it's fine.

Can you also add lower bound for base16-bytestring? My shell still reports base16-bytestring-0.1.1.7.

@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Dec 13, 2020 •
edited
Loading

Yes. One just needed to look at the decode* set of functions to understand why they got unified.

Now they can be unified into one function and get Left handled predictably & uniformly.

Thank you.

@Anton-Latukha Anton-Latukha merged commit ab19051 into haskell-nix:master Dec 13, 2020
@Anton-Latukha Anton-Latukha deleted the 2020-12-11-fx branch December 13, 2020 14:00
This was referenced Dec 14, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorki sorki sorki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Anton-Latukha @sorki