Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hnix-store-core.cabal: use base16-bytestring >= 1 #86

Merged
merged 2 commits into from
Dec 14, 2020
Merged

hnix-store-core.cabal: use base16-bytestring >= 1 #86

merged 2 commits into from
Dec 14, 2020

Conversation

Anton-Latukha
Copy link
Contributor

Regarding: #84 (review).

Can you also add lower bound for base16-bytestring? My shell still reports base16-bytestring-0.1.1.7.

sorki
sorki approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@sorki sorki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've added commit fixing tests.

@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Dec 14, 2020 •
edited
Loading

Thanks, sorry, tests do not run on my system currently:

ghc: could not execute: tasty-discover

so far I was lazy to debug it. tasty-discover is in the test-suite of .cabal.

@Anton-Latukha Anton-Latukha merged commit 4a1c1a2 into haskell-nix:master Dec 14, 2020
@Anton-Latukha Anton-Latukha deleted the 2020-12-14-ByteString-niceties branch December 14, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorki sorki sorki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Anton-Latukha @sorki