Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for servant 0.8 and elm compatibility #8

Merged
merged 1 commit into from
Sep 15, 2016

Conversation

purcell
Copy link
Contributor

@purcell purcell commented Sep 15, 2016

Heya, so I'm keen to use servant-elm with the latest servant version, and had a go at making that work. This PR contains the changes that seemed necessary and/or desirable as part of that process:

  • Removal of a now-clashing orphan instance
  • Bumps to lts-6.17
  • Switch elm-community/elm-json-extra to elm-community/json-extra

I noticed that there's an elm-export 0.4.0.1 in Hackage, but this doesn't work with servant-elm's code as-is, and it wasn't immediately obvious to me how to update the servant-elm code accordingly. With some pointers, that might be something I could tackle.

/cc @krisajenkins

- Removal of a now-clashing orphan instance
- Bumps to lts-6.17
- Switch elm-community/elm-json-extra to elm-community/json-extra
@mattjbray
Copy link
Collaborator

mattjbray commented Sep 15, 2016

Thanks!

Unfortunately updating to the latest elm-export is non-trivial, since servant-elm is currently using a fork that has some extra functionality - see krisajenkins/elm-export#4 and krisajenkins/elm-export#5.

The process at the moment is:

  1. Rebase those two PRs onto the devel branch in https://github.com/krisajenkins/elm-export. The rebasing is likely to be non-trivial.
  2. Over in https://github.com/mattjbray/elm-export create a new branch from the latest krisajenkins/devel, and merge in the two rebased PR branches. The merge is slightly non-trivial.
  3. Reference the resulting merge commit in this repo's stack.yaml.
  4. Update this repo for any API changes in elm-export.

If you want to take a stab at this feel free, otherwise I will do it some time over the next week.

@mattjbray mattjbray merged commit 58ce422 into haskell-servant:master Sep 15, 2016
@purcell
Copy link
Contributor Author

purcell commented Sep 16, 2016

Yeah, there's going to be more work than that because Kris has (very reasonably) switched from String to Text recently... :-)

@purcell
Copy link
Contributor Author

purcell commented Sep 17, 2016

So here's what I've done so far: I pointed the stack.yaml reference at the current tip of Kris' devel branch (8e64241a8ad5192afe87cdcb5b3791b886453aeb). That primarily turns up the differences you've submitted upstream in krisajenkins/elm-export#4, and then I got bogged down in understanding why those are necessary. I'm quite possibly just having a slow brain day.

@krisajenkins
Copy link

Hey folks,

I've done some fairly major rework of the internal datastructures for elm-export. It's still the same on the outside, but the branch you probably want to work off of is rework-adt. What's in there will eventually become v0.5.

So when's 'eventually'? Probably when I come up with a satisfying solution for krisajenkins/elm-export#6, which is still bugging me. Any suggestion on that are most welcome. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants