Only add a ? when query string is nonempty (#1589)

* Only add a ? when query string is nonempty * Adds changelog entry
haskell-servant · May 16, 2022 · 1fba9dc · 1fba9dc
1 parent 8ef5021
commit 1fba9dc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog.d/1589 b/changelog.d/1589
@@ -0,0 +1,2 @@
+synopsis: Only include question mark for nonempty query strings
+prs: 1589
diff --git a/servant-client/src/Servant/Client/Internal/HttpClient.hs b/servant-client/src/Servant/Client/Internal/HttpClient.hs
@@ -289,7 +289,8 @@ defaultMakeClientRequest burl r = Client.defaultRequest
         Https -> True
 
     -- Query string builder which does not do any encoding
-    buildQueryString = ("?" <>) . foldl' addQueryParam mempty
+    buildQueryString [] = mempty
+    buildQueryString qps = "?" <> foldl' addQueryParam mempty qps
 
     addQueryParam qs (k, v) =
           qs <> (if BS.null qs then mempty else "&") <> urlEncode True k <> foldMap ("=" <>) v