Add servant-client-jsaddle #1018

roberth · 2018-07-28T12:52:29Z

Contributions welcome :)

To do

hlint
see if it builds on the CI: no GHCJS dependency!
add usage example
improve typedarray use in sendXhr

phadej · 2018-11-08T16:39:38Z

Oh. This went completely under my radar. I'll check this tomorrow.

roberth · 2019-01-21T14:22:33Z

Blip. :)

alpmestan

@phadej OK with this?

phadej · 2019-01-21T17:20:01Z

I'll add this to travis first, let's see then.

vaibhavsagar · 2019-01-31T01:24:04Z

servant-client-jsaddle/test/Servant/Client/JsSpec.hs

+
+testServer :: Server TestApi
+testServer x = do
+  liftIO $ putStrLn "Hello tehre"


s/tehre/there/?

vaibhavsagar · 2019-01-31T01:25:02Z

Is there any way I can help move this along?

roberth · 2019-01-31T02:45:31Z

@phadej did you make any progress with travis ci?

alpmestan · 2019-01-31T11:06:20Z

Hello,

Sorry for the delay! Both @phadej and I have been quite busy lately. I think we just need to add this new package to the cabal.project file and use haskell-ci to regenerate the travis script. Do you feel like giving it a shot or do you want us to drive this home?

vaibhavsagar · 2019-01-31T15:51:56Z

@alpmestan I tried to do this here: roberth#1

alpmestan · 2019-01-31T19:08:40Z

@vaibhavsagar Your patch seems to be changing GHC versions, not just the list of packages to test?

vaibhavsagar · 2019-01-31T20:22:48Z

@alpmestan I think I misunderstood what you wanted me to do earlier. I've tried again now, can you have another look?

vaibhavsagar · 2019-01-31T20:38:21Z

I accidentally force-pushed to the wrong branch, sorry about that!

alpmestan · 2019-01-31T22:27:08Z

Is the diff against servant's master branch? Still seems like there are too many changes, wrt GHC versions etc.

@phadej knows better though, so he may have more precise feedback.

vaibhavsagar · 2019-01-31T22:59:42Z

Yes, the diff is against servant's master branch.

Attempt to generate .travis.yml using haskell-ci

alpmestan · 2019-02-01T17:00:15Z

Apparently there's a conflict with our current travis script now, so the job won't run... Sorry about that, do you want to look into it?

vaibhavsagar · 2019-02-01T17:10:42Z

Fixed.

alpmestan · 2019-02-01T17:25:49Z

OK, I now see:

cabal: Could not resolve dependencies:
[__0] trying: cookbook-basic-auth-0.1 (user goal)
[__1] trying: base-4.12.0.0/installed-4.1... (dependency of
cookbook-basic-auth)
[__2] next goal: servant-client-jsaddle (user goal)
[__2] rejecting: servant-client-jsaddle-0.13 (conflict:
base==4.12.0.0/installed-4.1..., servant-client-jsaddle => base>=4.7 && <4.11)
[__2] fail (backjumping, conflict set: base, servant-client-jsaddle)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: base, cookbook-basic-auth,
servant-client-jsaddle

phadej · 2019-02-02T08:59:12Z

jsaddle packages don't support recent versions of dependencies,
e.g. no install plan with GHC-8.6: https://matrix.hackage.haskell.org/#/package/jsaddle/0.9.5.0/ghc-8.6.3@1548602028

I had to add: and an install plan with GHC-8.4.4 is found: (didn't try to build though)

-- jsaddle
allow-newer:
jsaddle:aeson,
jsaddle:exceptions,
jsaddle:lens,
jsaddle-webkit2gtk:aeson,
jsaddle-webkit2gtk:haskell-gi-base,
jsaddle-dom:base-compat,
jsaddle-dom:lens

-- Ubuntu packages:
-- libgirepository1.0-dev
-- libwebkit2gtk-4.0-dev


`aeson` is restricted to `<1.3` (1.3.0.0 uploaded at Wed Mar 7 18:38:53 UTC 2018)
`exceptions` is <0.9; and (0.10 uploaded  at Sun Mar 11 15:01:38 UTC 2018)

---

I cannot commit to maintain `servant-client-jsaddle` if `jsaddle` itself isn't maintained. Getting `jsaddle` to track dependencies with less only few month lag is a hard requirement, unfortunately.

I pushed my branch to https://github.com/haskell-servant/servant/compare/wip-servant-client-jsaddle

vaibhavsagar · 2019-02-07T19:52:30Z

I can't seem to reproduce this build failure locally.

vaibhavsagar · 2019-02-07T20:24:59Z

Ah, it looks like this is due to 4fab471.

vaibhavsagar · 2019-02-08T16:10:20Z

The 8.4 and 8.6 builds are choking on building jsaddle-dom, and I'm beginning to think that replacing jsaddle-webkit2gtk with something else like jsaddle-warp might reduce the number of dependencies and finally allow this build to complete.

alpmestan · 2019-02-08T17:23:20Z

We have faith in you @vaibhavsagar.

phadej · 2019-02-08T17:29:19Z

Not requiring GUI toolkits is definitely a bonus

…

Sent from my iPhone

On 8 Feb 2019, at 19.23, Alp Mestanogullari ***@***.***> wrote: We have faith in you @vaibhavsagar. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

eskimor

Added PR for PR: #1122

eskimor · 2019-02-11T12:54:33Z

servant-client-jsaddle/servant-client-jsaddle.cabal

+    , http-media
+    , http-types
+    , jsaddle
+    , jsaddle-dom


Is there a good reason we are using jsaddle-dom instead of ghcjs-dom?

It is usually preferred to use ghcjs-dom instead of jsaddle-dom directly, as it avoids some overhead when compiled with ghcjs. Also as other libraries usually depend on ghcjs-dom- jsaddle-dom does become an additional build dependency when using servant-reflex-jsaddle right now.

I am going to provide a PR for this PR, changing that dependency and fixing some imports.

Reason was portability. Looks like ghcjs-dom provides the same portability, so sgtm.

@eskimor using ghcjs-dom might also unblock the 8.4 and 8.6 builds, which are currently failing when trying to compile JSDOM.Types

Probably not, as ghcjs-dom has a similar module - and on ghc it is even the same.

(ghcjs-dom uses jsaddle-dom on ghc under the hood)

This way we avoid the dependency on jsaddle-dom on ghcjs and have slightly better performance on ghcjs.

I did not run the tests though, as I have problems with some dependency.

Use ghcjs-dom

Make sure response gets handled even in case of exception.

dredozubov · 2019-05-15T15:07:04Z

I was able to build it with jsaddle-warp and updated 0.16: https://github.com/dredozubov/servant/tree/wip-servant-client-jsaddle-016 I've probably messed up the .travis.yml merge, but overall it's good news

hvr · 2019-05-30T09:47:32Z

servant-client-jsaddle/servant-client-jsaddle.cabal

+    , case-insensitive      >= 1.2.0.0  && < 1.3.0.0
+    , containers            >= 0.5      && < 0.7
+    , exceptions            >= 0.8      && < 0.11
+    , http-media


Why are version bounds ommitted for these deps?

servant-client-jsaddle/servant-client-jsaddle.cabal

Co-Authored-By: Herbert Valerio Riedel <hvr@gnu.org>

hvr · 2019-05-30T12:17:02Z

Btw, what's blocking this PR currently? Also, it seems like the .travis.yml file diverged from the merge base?

phadej · 2019-05-30T12:31:40Z

This version of the patch requires xfvb and libwebkit2gtk-4.0-dev and other crap from CI. I recall there was a branch of this branch which doesn't need all of that, but it didn't emerge into PR.

To be clear: I know very little about jsaddle, so cannot cleanup myself. This PR isn't such I could just press merge.

dredozubov · 2019-05-30T15:48:01Z

I have a branch that I updated to use 0.16 https://github.com/dredozubov/servant/tree/wip-servant-client-jsaddle-016

It has a few rough edges: I may have screwed up the merge of .travis.yml(I haven't bothered to check) and I skipped the streaming part for the request handling. Nonetheless, it builds with jsaddle-warp and I've used it in an application.

Should I force-push it here or create a PR for this PR?

phadej · 2019-05-30T17:09:59Z

.travis.yml can be regenerated with haskell-ci, if it conflicts, just regenerate.

This is @roberths branch, I have no idea who can or cannot push there; but I wouldn't.

eskimor · 2019-05-30T20:00:14Z

@dredozubov just create a PR for the PR and ping me.

phadej · 2019-05-30T20:36:47Z

Btw, I'd like the clean-history PR at the end. Dozens of commits with merge commits in between won't be merged.

phadej · 2019-09-28T14:50:11Z

servant-jsaddle merged.

Add servant-client-jsaddle

a04db2b

roberth mentioned this pull request Jul 28, 2018

Add servant-client-ghcjs to hackage and stackage #939

Closed

alpmestan approved these changes Sep 21, 2018

View reviewed changes

alpmestan approved these changes Jan 21, 2019

View reviewed changes

vaibhavsagar reviewed Jan 31, 2019

View reviewed changes

servant-client-jsaddle: Remove some debug printing

85d6471

vaibhavsagar mentioned this pull request Jan 31, 2019

Use servant-client-ghcjs kadena-io/chainweaver#80

Closed

vaibhavsagar force-pushed the servant-client-jsaddle branch from aa2498d to 85d6471 Compare January 31, 2019 20:37

Update .travis.yml with haskell-ci

7ce6db7

Merge pull request #1 from roberth/vs-servant-client-jsaddle

3d16ece

Attempt to generate .travis.yml using haskell-ci

Merge branch 'master' into servant-client-jsaddle

dcf0a49

vaibhavsagar mentioned this pull request Feb 1, 2019

New release of jsaddle-webkit2gtk? ghcjs/jsaddle#83

Closed

phadej added the blocked label Feb 2, 2019

servant-client-jsaddle: bump base bounds

c5ae9d9

Vaibhav Sagar added 3 commits February 7, 2019 16:03

servant-client-jsaddle: fix compatibility

c5c3bd9

servant-client-jsaddle: import correct module

5b9263c

.travis.yml: run xvfb for headless GUI testing

bb8bfb2

eskimor suggested changes Feb 11, 2019

View reviewed changes

phadej mentioned this pull request Apr 22, 2019

Use ghcjs-dom instead of jsaddle-dom directly. #1122

Closed

eskimor and others added 8 commits April 23, 2019 10:54

Use ghcjs-dom instead of jsaddle-dom directly.

d59c8f4

This way we avoid the dependency on jsaddle-dom on ghcjs and have slightly better performance on ghcjs.

Also use ghcjs-dom in tests.

e4d6dcf

I did not run the tests though, as I have problems with some dependency.

Ignore exceptions on send - they are handled in toResponse.

adeecb5

Apparently ghcjs-dom does use the same exception these days.

002520b

Got rid of obsolete comment.

1910830

Merge pull request #2 from eskimor/use-ghcjs-dom-correct

73452de

Use ghcjs-dom

Make sure response gets handled even in case of exception.

3dd79ca

Merge pull request #3 from eskimor/use-ghcjs-dom-correct

a70d305

Make sure response gets handled even in case of exception.

hvr reviewed May 30, 2019

View reviewed changes

servant-client-jsaddle/servant-client-jsaddle.cabal Outdated Show resolved Hide resolved

Update servant-client-jsaddle/servant-client-jsaddle.cabal

88292b4

Co-Authored-By: Herbert Valerio Riedel <hvr@gnu.org>

phadej closed this Sep 28, 2019

Add servant-client-jsaddle #1018

Add servant-client-jsaddle #1018

Conversation

roberth commented Jul 28, 2018 • edited Loading

To do

phadej commented Nov 8, 2018

roberth commented Jan 21, 2019

alpmestan left a comment

Choose a reason for hiding this comment

phadej commented Jan 21, 2019

Choose a reason for hiding this comment

vaibhavsagar commented Jan 31, 2019

roberth commented Jan 31, 2019

alpmestan commented Jan 31, 2019

vaibhavsagar commented Jan 31, 2019

alpmestan commented Jan 31, 2019

vaibhavsagar commented Jan 31, 2019

vaibhavsagar commented Jan 31, 2019

alpmestan commented Jan 31, 2019

vaibhavsagar commented Jan 31, 2019

alpmestan commented Feb 1, 2019 • edited Loading

vaibhavsagar commented Feb 1, 2019

alpmestan commented Feb 1, 2019

phadej commented Feb 2, 2019

vaibhavsagar commented Feb 7, 2019

vaibhavsagar commented Feb 7, 2019

vaibhavsagar commented Feb 8, 2019

alpmestan commented Feb 8, 2019

phadej commented Feb 8, 2019 via email

eskimor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dredozubov commented May 15, 2019

Choose a reason for hiding this comment

hvr commented May 30, 2019

phadej commented May 30, 2019

dredozubov commented May 30, 2019 • edited Loading

phadej commented May 30, 2019

eskimor commented May 30, 2019

phadej commented May 30, 2019

phadej commented Sep 28, 2019

roberth commented Jul 28, 2018 •

edited

Loading

alpmestan commented Feb 1, 2019 •

edited

Loading

dredozubov commented May 30, 2019 •

edited

Loading