New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GHC-9.4 #1592
Support GHC-9.4 #1592
Conversation
Now that 9.4 has been released I'll try to tidy this up in the next couple of days |
Currently everything builds except I feel like the changes to |
bc792fa
to
9c36606
Compare
@TeofilC Thanks a lot for this. I just allowed CI to run for this branch. I'll try to keep an eye on this PR, let me know when you consider this ready (i.e the doctest business is sorted out etc). Cheers! |
Still waiting on some things but I've updated the overrides and listed the allow-newers |
Cross reference: #1608 |
Just a quick update on this. We are still waiting on sol/doctest to support 9.4 as well as the postgresql packages to bump bounds. |
In GHC-9.4 the typechecker changed requiring more annotations in positions like this. See https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4#ambiguous-types-containing-a-typeerror and https://gitlab.haskell.org/ghc/ghc/-/issues/21149
I've rebased on top of master and updated the cabal.project to use sol/doctest HEAD, which supports 9.4. I have the doctests passing locally now. We are waiting on some hackage releases/ version bumps in order to be able to drop stuff from the cabal.project. It looks like there is a genuine failure on the ghcjs 8.6 test suite because it doesn't seem to support the type applications syntax that I'm using to fix stuff for 9.4. There's several ways we could fix this:
|
After some thought, I vote in favour of 2. |
I've added a commit that implements that option. |
cdb8276
to
9b52e7a
Compare
I've merged servant-multipart and servant-js PRs, please update this one. |
I'll take a look at the doctest failures tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like CI for 9.4 failed
The doctest failures are caused by GHC's error output changing. It used to produce message that start with I'm going to update the tests to just expect |
Thanks! Published Hackage revisions:
New versions:
|
Thank you @TeofilC |
This is an early attempt to get this working with GHC-9.4.1.
At the moment we need to use some patched versions of libraries taken from yesodweb/yesod#1769
There's also an issue with changes to the constraint solver and TypeErrors (upstream issue: https://gitlab.haskell.org/ghc/ghc/-/issues/21677). I've worked around it by applying some TypeApplications.
This is mostly just here to save work for others who want to try using 9.4