Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[servant] Generalize type of Servant.Types.SourceT.source to any foldable #1593

Merged
merged 3 commits into from Apr 11, 2023
Merged

[servant] Generalize type of Servant.Types.SourceT.source to any foldable #1593

merged 3 commits into from Apr 11, 2023

Conversation

Daniel-Diaz
Copy link
Contributor

I didn't see any reason to restrict this function to only work on lists, so I changed the type signature from

source :: [a] -> SourceT m a

to

source :: Foldable f => f a -> SourceT m a

@Daniel-Diaz Daniel-Diaz changed the title Generalize type of Servant.Types.SourceT.source to any foldable [servant] Generalize type of Servant.Types.SourceT.source to any foldable Jun 4, 2022
@jkarni jkarni merged commit 4244ae5 into haskell-servant:master Apr 11, 2023
@Daniel-Diaz
Copy link
Contributor Author

Thanks for the merge!

@ysangkok ysangkok mentioned this pull request Apr 28, 2023
Merged
@mwotton mwotton mentioned this pull request Aug 16, 2023
Open
@ysangkok ysangkok mentioned this pull request Oct 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpmestan alpmestan alpmestan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Daniel-Diaz @alpmestan @jkarni