Handle Cookies correctly for RunStreamingClient #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly bump :) I think it's a straightforward addition (other functions are doing it) and I've been using this patch on my fork for a while now |
|
@alt-romes perfect, glad to hear this is going well in production. :) |
tchoutri
approved these changes
Oct 23, 2022
|
@alt-romes Could you please add a changelog entry? It should be good to merge after that. :) |
Makes `performWithStreamingRequest` take into consideration the CookieJar, which it previously didn't. It's now possible to e.g. use the servant-client generated functions to access a streaming endpoint that depends on a cookie being set to authenticate the user Fixes haskell-servant#1605
alt-romes
force-pushed
the
streaming+cookies
branch
from
bc2008b
to
e455fa9
Compare
|
@tchoutri Done |
|
@tchoutri light ping, let's close this one? |
|
Ah, I somehow missed your original ping! Let's go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
performWithStreamingRequesttake into consideration theCookieJar, which it previously didn't.
It's now possible to e.g. use the servant-client generated functions to
access a streaming endpoint that depends on a cookie being set to
authenticate the user
Fixes #1605