Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromSourceIO: Run in IO. #1661

Merged
merged 1 commit into from Jun 20, 2023
Merged

Conversation

shlevy
Copy link
Contributor

@shlevy shlevy commented Mar 17, 2023

Needed for stateful initialization like io-streams.

@shlevy
Copy link
Contributor Author

shlevy commented Apr 18, 2023

Any thoughts?

@ysangkok
Copy link
Contributor

@shlevy It looks good, but I think the changelog entry should be in the changelog.d directory like it is for other PRs. When that change is made, I will merge this. Sorry for the delay.

@shlevy
Copy link
Contributor Author

shlevy commented Jun 19, 2023

@ysangkok Cool, will take a look tomorrow.

Needed for stateful initialization like io-streams.
@shlevy
Copy link
Contributor Author

shlevy commented Jun 20, 2023

@ysangkok Done

@ysangkok ysangkok merged commit 88408e4 into haskell-servant:master Jun 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants