Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 9.2 #885

Closed
Tracked by #2328
andreasabel opened this issue Oct 30, 2021 · 9 comments
Closed
Tracked by #2328

Support GHC 9.2 #885

andreasabel opened this issue Oct 30, 2021 · 9 comments

Comments

@andreasabel
Copy link
Member

andreasabel commented Oct 30, 2021

Latest aeson-2 is currently rejected because of bounds on ghc-prim and template-haskell.

Blocking:

@bergmark
Copy link
Collaborator

I'll file a PR for this

@bergmark
Copy link
Collaborator

bergmark commented Oct 31, 2021

Or perhaps not yet, @phadej the test-suite is blocked on quickcheck-instances => time-compat => splitmix (looks like it goes even deeper!)

@bergmark
Copy link
Collaborator

Heh, and our library is blocked on pretty much every dependency. Need to hold off on this for a while!

@andreasabel
Copy link
Member Author

NB: splitmix is already operational:

@andreasabel
Copy link
Member Author

andreasabel commented Nov 2, 2021

With ghc-prim and template-haskell relaxed, the library aeson-2.0.1.0 (master branch) builds fine. But aeson-tests fails with:

Building test suite 'aeson-tests' for aeson-2.0.1.0..
...
[ 5 of 23] Compiling Types            ( tests/Types.hs, ... )

tests/Types.hs:21:24: error:
    Module ‘Data.Semigroup’ does not export ‘Option’
   |
21 | import Data.Semigroup (Option)
   |                        ^^^^^^

Looks like the dependencies are fine now!

UPDATE: I see that there is draft PR #856 to fix GHC 9.2 build.

@andreasabel
Copy link
Member Author

@bergmark Can PR #856 maybe help to fix this issue?

@phadej
Copy link
Collaborator

phadej commented Nov 7, 2021

#856, is a good start, but I'm waiting for hashable-1.4 compatible unordered-containers release to get everything done at once. This library is not abandoned.

@vmchale
Copy link

vmchale commented Nov 9, 2021

@andreasabel also blocking microstache and thus criterion!

@andreasabel
Copy link
Member Author

andreasabel commented Nov 13, 2021

Fixed by the release of aeson-2.0.2.0 (although the https://hackage.haskell.org/package/aeson-2.0.2.0/changelog is silent about it).

Thanks, @phadej and @awjchen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants