Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 9.2 #2328

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Support GHC 9.2 #2328

merged 3 commits into from
Nov 11, 2021

Conversation

sjakobi
Copy link
Collaborator

@sjakobi sjakobi commented Nov 9, 2021

Some dependencies aren't compatible yet, so I'm currently using this incantation:

cabal build all -O0 -w ghc-9.2 --allow-newer=basement:base,aeson:ghc-prim,aeson:template-haskell,modern-uri:template-haskell,relude:base,relude:ghc-prim,aeson-yaml:aeson,hnix:template-haskell,hnix:time,turtle:bytestring,tomland:base,validation-selective:base

…and this patch (due to #2270):

--- a/cabal.project
+++ b/cabal.project
@@ -1 +1 @@
-packages: ./dhall ./dhall-bash ./dhall-json ./dhall-yaml ./dhall-lsp-server ./dhall-nix ./dhall-docs ./dhall-openapi ./dhall-nixpkgs ./dhall-csv ./dhall-toml
+packages: ./dhall ./dhall-bash ./dhall-json ./dhall-yaml ./dhall-nix ./dhall-docs ./dhall-openapi ./dhall-nixpkgs ./dhall-csv ./dhall-toml

Blocked on:

Copy link
Collaborator

@Gabriella439 Gabriella439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge whenever this is ready

@sjakobi
Copy link
Collaborator Author

sjakobi commented Nov 11, 2021

So I can already get a clean build with head.hackage (and --allow-newer). The one minor hurdle is https://gitlab.haskell.org/ghc/ghc/-/issues/20666, which prevents generic-random from building. I've worked around this by excluding that dependency and the Dhall.Test.QuickCheck module where generic-random is used.

Since no further changes in this project seem necessary, I'll merge and create a matching Hackage revision.

I hope it won't be too long until we can migrate CI to GHC 9.2 – the compiler perf benefits seem very promising. I haven't done any measurements yet though!

@sjakobi sjakobi marked this pull request as ready for review November 11, 2021 17:38
@mergify mergify bot merged commit 76b7437 into master Nov 11, 2021
@mergify mergify bot deleted the sjakobi/ghc-9.2 branch November 11, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants