Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instances for Down from Data.Ord? #983

Closed
imuli opened this issue Dec 7, 2022 · 0 comments
Closed

instances for Down from Data.Ord? #983

imuli opened this issue Dec 7, 2022 · 0 comments

Comments

@imuli
Copy link

imuli commented Dec 7, 2022

I occasionally run into an instance where I want to use Down in a data type, use genericToJSON, and end up needing to write the orphan instances (or make my own type for it):

deriving instance ToJSON a => ToJSON (Down a)
deriving instance FromJSON a => FromJSON (Down a)

It's not that big of a deal, but it would be nice if these were included, like most other types in base.
@phadej phadej closed this as completed in b369630 Jun 19, 2023
phadej added a commit that referenced this issue Jun 19, 2023
@phadej
Merge pull request #1044 from haskell/issue-983-down
328e907 
Resolve #983. Add instances for Data.Ord.Down
JonathanLorimer pushed a commit to JonathanLorimer/aeson that referenced this issue Aug 7, 2023
@phadej @JonathanLorimer
Resolve haskell#983. Add instances for Data.Ord.Down
a468501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@imuli