Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #311 #353

Merged
merged 2 commits into from
Feb 4, 2016
Merged

Resolve #311 #353

merged 2 commits into from
Feb 4, 2016

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Feb 2, 2016 

> putStrLn $ formatError [Index 0, Key "foo", Key "bar", Key "a.b.c", Key "", Key "'\\", Key "end"] "error msg"
Error in $[0].foo.bar['a.b.c']['']['\'\\'].end: error msg

@bergmark
Copy link
Collaborator

bergmark commented Feb 2, 2016

Looks good, thanks! Can you please add some tests for this?

@phadej
Copy link
Collaborator Author

phadej commented Feb 3, 2016

I don't know why GHC8.0 build suddenly failed.

@hvr
Copy link
Member

hvr commented Feb 3, 2016

@phadej the GHC 8.0 ppa snapshot was updated last night, and this required a travis cache wipe... this will get more robust with cabal new-build

@bergmark
Copy link
Collaborator

bergmark commented Feb 4, 2016

👍

bergmark added a commit that referenced this pull request Feb 4, 2016
@bergmark
Merge pull request #353 from phadej/issue-311
28f5f5c 
Resolve #311
@bergmark bergmark merged commit 28f5f5c into haskell:master Feb 4, 2016
@phadej phadej deleted the issue-311 branch February 4, 2016 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phadej @bergmark @hvr