Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Data.ByteString.Lazy.Builder.* #250

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Deprecate Data.ByteString.Lazy.Builder.* #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a273ead
Deprecate Data.ByteString.Lazy.Builder
fumieval Jul 6, 2020
3fc6256
Merge branch 'master' into deprecate-Lazy-Builder
sjakobi Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* Add `takeWhileEnd`, `dropWhileEnd` and `strip` for strict bytestrings
* Define `findIndexEnd`
* Add `IsList` instances
* Deprecate `Data.ByteString.Lazy.Builder`
sjakobi marked this conversation as resolved.
Show resolved Hide resolved
* Add `partition` to `Data.ByteString.Char8` and `Data.ByteString.Lazy.Char8`

0.10.10.1 – June 2020
Expand Down
6 changes: 3 additions & 3 deletions Data/ByteString/Lazy/Builder.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@

-- | We decided to rename the Builder modules. Sorry about that.
--
-- The old names will hang about for at least once release cycle before we
-- deprecate them and then later remove them.
-- The old names will hang about for at least once release cycle and then later remove them.
--
module Data.ByteString.Lazy.Builder (
module Data.ByteString.Lazy.Builder
{-# DEPRECATED "Use Data.ByteString.Builder instead" #-} (
module Data.ByteString.Builder
) where

Expand Down
8 changes: 5 additions & 3 deletions Data/ByteString/Lazy/Builder/ASCII.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
-- In additon, the ASCII module has been merged into the main
-- "Data.ByteString.Builder" module.
--
-- The old names will hang about for at least once release cycle before we
-- deprecate them and then later remove them.
-- The old names will hang about for at least once release cycle and then later remove them.
--
module Data.ByteString.Lazy.Builder.ASCII (
module Data.ByteString.Lazy.Builder.ASCII
{-# DEPRECATED "Use Data.ByteString.Builder instead" #-} (
module Data.ByteString.Builder
, byteStringHexFixed
, lazyByteStringHexFixed
Expand All @@ -19,6 +19,8 @@ import qualified Data.ByteString.Lazy as L

byteStringHexFixed :: S.ByteString -> Builder
byteStringHexFixed = byteStringHex
{-# DEPRECATED byteStringHexFixed "Use byteStringHex instead" #-}

lazyByteStringHexFixed :: L.ByteString -> Builder
lazyByteStringHexFixed = lazyByteStringHex
{-# DEPRECATED lazyByteStringHexFixed "Use lazyByteStringHex instead" #-}
6 changes: 3 additions & 3 deletions Data/ByteString/Lazy/Builder/Extras.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@

-- | We decided to rename the Builder modules. Sorry about that.
--
-- The old names will hang about for at least once release cycle before we
-- deprecate them and then later remove them.
-- The old names will hang about for at least once release cycle and then later remove them.
--
module Data.ByteString.Lazy.Builder.Extras (
module Data.ByteString.Lazy.Builder.Extras
{-# DEPRECATED "Use Data.ByteString.Builder.Extra instead" #-} (
module Data.ByteString.Builder.Extra
) where

Expand Down