Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Data.ByteString.Lazy.Builder.* #250

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Deprecate Data.ByteString.Lazy.Builder.* #250

merged 2 commits into from
Jul 13, 2020

Conversation

fumieval
Copy link
Contributor

@fumieval fumieval commented Jul 6, 2020

It's been planned to deprecate for 8 years, so let's do this.

sjakobi
sjakobi reviewed Jul 6, 2020
View reviewed changes
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'd slightly prefer to have the benchmark changes in a separate PR, unless they are somehow entangled with the deprecation?!

Changelog.md Show resolved Hide resolved
@fumieval
Copy link
Contributor Author

fumieval commented Jul 6, 2020

I'd slightly prefer to have the benchmark changes in a separate PR, unless they are somehow entangled with the deprecation?!

It was mainly because I noticed that CSV.hs imports Data.ByteString.Lazy.Builder. I can move it to a separate PR.

@sjakobi
Copy link
Member

sjakobi commented Jul 7, 2020

I'd slightly prefer to have the benchmark changes in a separate PR, unless they are somehow entangled with the deprecation?!

To be clear: I thought that reactivating the CSV benchmark was a very nice idea, so I hope you'll put up that commit in a different PR, @fumieval! :)

@sjakobi sjakobi merged commit c05b316 into haskell:master Jul 13, 2020
dcoutts
dcoutts reviewed Aug 1, 2020
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good.

@fumieval fumieval mentioned this pull request Sep 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts dcoutts left review comments

@Bodigrim Bodigrim Bodigrim approved these changes

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fumieval @sjakobi @dcoutts @Bodigrim