Fix detection of endianness in test suite #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjakobi
reviewed
Sep 11, 2021
There was a problem hiding this comment.
I find it a bit difficult to understand what this PR does, in part because I'm unfamiliar with endianness issues. I think this would be helpful:
- Move the
dlistchanges to a separate PR. - Create an issue that describes the problem and reference it from this PR.
Bodigrim
force-pushed
the
big-endian
branch
from
b40c659
to
d3d73db
Compare
Closed
sjakobi
approved these changes
Sep 11, 2021
tests/Properties/ByteString.hs
Outdated
| let prop x = ioProperty $ do | ||
| r <- B.fromFilePath x >>= B.toFilePath | ||
| pure (r === x) | ||
| -- Normally getFileSystemEncoding returns one of Unicode encodings, |
There was a problem hiding this comment.
Suggested change
| -- Normally getFileSystemEncoding returns one of Unicode encodings, | |
| -- Normally getFileSystemEncoding returns a Unicode encoding, |
Bodigrim
force-pushed
the
big-endian
branch
from
d3d73db
to
5e13a79
Compare
Bodigrim
added a commit
to Bodigrim/bytestring
that referenced
this pull request
Sep 12, 2021
* Fix detection of endianness in test suite (haskell#421) * Work around when getFileSystemEncoding is ASCII (haskell#421)
noughtmare
pushed a commit
to noughtmare/bytestring
that referenced
this pull request
Dec 12, 2021
* Fix detection of endianness in test suite (haskell#421) * Work around when getFileSystemEncoding is ASCII (haskell#421)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with
and then in s390x virtual machine:
apt update apt install -y ghc cabal-install git git clone https://github.com/haskell/bytestring cd bytestring/ cabal new-update cabal -j1 new-test test:test-builderIn an emulated environment it takes three hours to build, so at some point it appeared faster to scrap
dlistdependency than build it :)