Try to test gcc_s error wrt #498 #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would probably try PowerShell instead of bash and scrap PATH completely. |
|
Alright, here we have it reproduced and proof that @bgamari's commit fixes it. I'm assuming that the msys2 toolchain leaks through when |
|
Excellent, many thanks! Could you please move Windows job out of |
Bodigrim
reviewed
Mar 12, 2022
The windows test should fail here.
This dependency causes an unnecessary dynamic dependency on Windows, resulting in GHC #21196. Fixes haskell#497.
Bodigrim
approved these changes
Mar 12, 2022
|
Thanks for picking this up, @hasufell ! |
|
LGTM!
ˌbodʲɪˈɡrʲim ***@***.***> schrieb am Sa., 12. März 2022,
16:59:
… @Bodigrim <https://github.com/Bodigrim> requested your review on: #500
<#500> Try to test gcc_s error
wrt #498 <#498>.
—
Reply to this email directly, view it on GitHub
<#500 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA36VCZQFR3AO6D4KIXQHL3U7S5NVANCNFSM5QRZANIA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Please create a release. |
sjakobi
added a commit
that referenced
this pull request
Mar 14, 2022
Follow-up to #500, which removed the gcc_s extra-library dependency.
sjakobi
added a commit
that referenced
this pull request
Mar 14, 2022
Follow-up to #500, which removed the gcc_s extra-library dependency.
Bodigrim
pushed a commit
to Bodigrim/bytestring
that referenced
this pull request
Mar 22, 2022
* Test gcc_s error wrt haskell#498 The windows test should fail here. * Eliminate redundant dependency on libgcc_s on Windows This dependency causes an unnecessary dynamic dependency on Windows, resulting in GHC #21196. Fixes haskell#497. Co-authored-by: Ben Gamari <ben@smart-cactus.org>
Bodigrim
pushed a commit
to Bodigrim/bytestring
that referenced
this pull request
Mar 22, 2022
Follow-up to haskell#500, which removed the gcc_s extra-library dependency.
adithyaov
added a commit
to psibi/streamly-bytestring
that referenced
this pull request
Jul 29, 2022
bytestring-0.11.3.0 causes panics and other issues on windows. the current constraint doesn't make sense from a PVP point of view either. * https://gitlab.haskell.org/ghc/ghc/-/issues/21179 * haskell/bytestring#500 Co-authored-by: Julian Ospald <hasufell@posteo.de>
adithyaov
added a commit
to psibi/streamly-bytestring
that referenced
this pull request
Jul 29, 2022
bytestring-0.11.3.0 causes panics and other issues on windows. the current constraint doesn't make sense from a PVP point of view either. * https://gitlab.haskell.org/ghc/ghc/-/issues/21179 * haskell/bytestring#500 Co-authored-by: Julian Ospald <hasufell@posteo.de>
adithyaov
added a commit
to psibi/streamly-bytestring
that referenced
this pull request
Sep 16, 2022
bytestring-0.11.3.0 causes panics and other issues on windows. the current constraint doesn't make sense from a PVP point of view either. * https://gitlab.haskell.org/ghc/ghc/-/issues/21179 * haskell/bytestring#500 Co-authored-by: Julian Ospald <hasufell@posteo.de>
adithyaov
added a commit
to psibi/streamly-bytestring
that referenced
this pull request
Oct 3, 2022
bytestring-0.11.3.0 causes panics and other issues on windows. the current constraint doesn't make sense from a PVP point of view either. * https://gitlab.haskell.org/ghc/ghc/-/issues/21179 * haskell/bytestring#500 Co-authored-by: Julian Ospald <hasufell@posteo.de>
adithyaov
added a commit
to psibi/streamly-bytestring
that referenced
this pull request
Feb 28, 2023
bytestring-0.11.3.0 causes panics and other issues on windows. the current constraint doesn't make sense from a PVP point of view either. * https://gitlab.haskell.org/ghc/ghc/-/issues/21179 * haskell/bytestring#500 Co-authored-by: Julian Ospald <hasufell@posteo.de>
adithyaov
added a commit
to psibi/streamly-bytestring
that referenced
this pull request
Mar 20, 2023
bytestring-0.11.3.0 causes panics and other issues on windows. the current constraint doesn't make sense from a PVP point of view either. * https://gitlab.haskell.org/ghc/ghc/-/issues/21179 * haskell/bytestring#500 Co-authored-by: Julian Ospald <hasufell@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.