New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print final conflict set when dependency solver fails after an exhaustive search #3570

Closed

grayjay opened this issue Jul 17, 2016 · 3 comments

Labels

cabal-install: solver type: enhancement

Collaborator

grayjay commented Jul 17, 2016 •

edited

Loading

@kosmikus suggested showing this message at default verbosity because it is often more relevant than the summarized log.

EDIT:
The new message could go here:

cabal/cabal-install/Distribution/Solver/Modular/Log.hs

Line 86 in c116df4

(if exh then "Dependency tree exhaustively searched.\n"

This is where the solver prints a message after an exhaustive search. It already has access to the final conflict set, cs.

I would add a unit test to Solver.hs. Here is an example of a test that checks for a specific error message:

cabal/cabal-install/tests/UnitTests/Distribution/Solver/Modular/Solver.hs

Line 45 in c116df4

    
           , runTest $         mkTest db22 "unknownPackage2"   ["A"]      (SolverFailure (isInfixOf "unknown package: C"))

The text was updated successfully, but these errors were encountered:

grayjay added type: enhancement cabal-install: solver attention: pr-welcome labels

Contributor

ezyang commented Jul 17, 2016

@grayjay, if PR is welcome, could you edit your message to say where the code is that you would update to make this change, and how you would test it? Thanks!

grayjay removed the attention: pr-welcome label

Collaborator Author

grayjay commented Jul 17, 2016

I realized that the hardest part of this issue is coming up with helpful wording. The task isn't as well-defined as I thought, so I removed the label.

fmthoma added a commit to fmthoma/cabal that referenced this issue


          Print final conflict set (haskell#3570)

5d64a15

Keep information about the final conflict set and print it in case of
exhaustive search. The original error message is not printed any more.

fmthoma added a commit to fmthoma/cabal that referenced this issue


          Print conflict counts alongside the conflicts (haskell#3570)

0e91089

Conflicts are sorted by conflict counts, so high-rated conflicts appear
early in the list. Currently the raw count is printed.

This was referenced Oct 8, 2016

Print final conflict set when search is exhaustive #3960

Merged

Fix conflict counting bug #3961

Merged

kosmikus added the meta: kosmikus label

fmthoma added a commit to fmthoma/cabal that referenced this issue


          Print final conflict set (haskell#3570)

f1bf334

Keep information about the final conflict set and print it in case of
exhaustive search. The original error message is not printed any more.

fmthoma added a commit to fmthoma/cabal that referenced this issue


          Print conflict counts alongside the conflicts (haskell#3570)

2255a49

Conflicts are sorted by conflict counts, so high-rated conflicts appear
early in the list. Currently the raw count is printed.

fmthoma added a commit to fmthoma/cabal that referenced this issue


          Print final conflict set (haskell#3570)

93fb5f4

Keep information about the final conflict set and print it in case of
exhaustive search. The original error message is not printed any more.

fmthoma added a commit to fmthoma/cabal that referenced this issue


          Print conflict counts alongside the conflicts (haskell#3570)

2587b71

Conflicts are sorted by conflict counts, so high-rated conflicts appear
early in the list. Currently the raw count is printed.

fmthoma added a commit to fmthoma/cabal that referenced this issue


          Print final conflict set (haskell#3570)

954ac75

Keep information about the final conflict set and print it in case of
exhaustive search. The original error message is not printed any more.

fmthoma added a commit to fmthoma/cabal that referenced this issue


          Print conflict counts alongside the conflicts (haskell#3570)

a09d57d

Conflicts are sorted by conflict counts, so high-rated conflicts appear
early in the list. Currently the raw count is printed.

fmthoma mentioned this issue

Add test suite with two basic tests for solver space leaks. #4122

Merged

fmthoma added a commit to fmthoma/cabal that referenced this issue


          Print final conflict set (haskell#3570)

c8c1ed6

Keep information about the final conflict set and print it in case of
exhaustive search. The original error message is not printed any more.

fmthoma added a commit to fmthoma/cabal that referenced this issue


          Print conflict counts alongside the conflicts (haskell#3570)

c3a89db

Conflicts are sorted by conflict counts, so high-rated conflicts appear
early in the list. Currently the raw count is printed.

grayjay mentioned this issue

Should we remove the package version from flag/stanza variables in the solver? #4142

Closed

fmthoma added a commit to fmthoma/cabal that referenced this issue


          Print final conflict set (haskell#3570)

67c8957

Keep information about the final conflict set and print it in case of
exhaustive search. The original error message is not printed any more.

fmthoma added a commit to fmthoma/cabal that referenced this issue


          Print conflict counts alongside the conflicts (haskell#3570)

e83ba10

Conflicts are sorted by conflict counts, so high-rated conflicts appear
early in the list. Currently the raw count is printed.

Collaborator Author

grayjay commented Dec 4, 2016

Added in #3960.

grayjay closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment