Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tasty-quickcheck 0.11 #10136

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Conversation

geekosaur
Copy link
Collaborator

@geekosaur geekosaur commented Jun 22, 2024

tasty-quickcheck 0.11, which was just released, is API incompatible with earlier versions. Exclude it from build plans. (Why were we using it without an upper bound?)

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur
Copy link
Collaborator Author

Sorting out where it needs to be changed.

@geekosaur geekosaur force-pushed the skip-tasty-1.5.1 branch 2 times, most recently from a5563cd to 22246f4 Compare June 22, 2024 22:20
@geekosaur geekosaur changed the title Skip tasty 1.5.1 Skip tasty-quickcheck 0.11 Jun 22, 2024
@geekosaur geekosaur marked this pull request as ready for review June 22, 2024 22:46
@geekosaur
Copy link
Collaborator Author

I think that, since this may delay the release if we need to make fixes after the candidate goes up, we should skip the delay on this one.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the change for Mergify config a part of this PR?

@ulysses4ever
Copy link
Collaborator

agree on skipping the delay btw

@geekosaur
Copy link
Collaborator Author

Ugh, I thought I switched to master before making this branch. Lemme nuke it.

@geekosaur
Copy link
Collaborator Author

Reverted mergify.yml to its state before the incorrectly incorporated commits.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geekosaur
Copy link
Collaborator Author

Hm, commits still show as present, although a squash will fix that. Dunno if it's worth mangling the repo to fix.

API incompatible with our test suites
@geekosaur
Copy link
Collaborator Author

Okay, history is clean now.

@geekosaur geekosaur added merge me Tell Mergify Bot to merge merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Jun 23, 2024
@Kleidukos
Copy link
Member

Cheers @geekosaur

@mergify mergify bot merged commit c39022a into haskell:master Jun 23, 2024
52 checks passed
@geekosaur
Copy link
Collaborator Author

@mergify backport 3.12

Copy link
Contributor

mergify bot commented Jun 23, 2024

backport 3.12

✅ Backports have been created

mergify bot added a commit that referenced this pull request Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-backport 3.12 attention: needs-review merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge priority: high 🔥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants