Add field for setting framework search path (fixes #182). #3176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @komadori |
|
Ah, you beat me to it! One difference between that and my own patch is that I made the check PackageDistWarning rather than PackageDistInexcusable, so that you wouldn't be forced to raise the minimum Cabal version for users not using MacOS or shared libraries, but MacOS users would still pick it up if they had a recent enough Cabal. What do you think? Also, the new entry in "Cabal/doc/installing-packages.markdown" has the wrong option name. |
* Renamed to 'extra-framework-dirs'. * Added 'extra-framework-dirs' to ConfigFlags. * Added some checks. * Updated changelog.
23Skidoo
force-pushed
the
framework-dirs
branch
from
bb84934
to
b9571ab
Compare
|
@komadori Thanks! Fixed the copy-pasto and changed the check to use |
23Skidoo
added a commit
that referenced
this pull request
Feb 20, 2016
Add field for setting framework search path (fixes #182).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An updated version of #3158 with the following changes:
framework-dirstoextra-framework-dirs.extra-framework-dirstoConfigFlags.D.PD.Check.