New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current pkg info to generated `cabal_macros.h` file #3235

Merged
merged 1 commit into from Mar 19, 2016

Conversation

Projects
None yet
2 participants
@erikd
Copy link
Member

erikd commented Mar 19, 2016

Add the version string macro for the package currently being built
to the generated dist/build/autogen/cabal_macros.h file. Perviously
this file only contained the version strings of all the dependent
packages, but not the version string of the package itself.

Add current pkg info to generated `cabal_macros.h` file
Add the version string macro for the package currently being built
to the generated `dist/build/autogen/cabal_macros.h` file. Perviously
this file only contained the version strings of all the dependent
packages, but not the version string of the package itself.
@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Mar 19, 2016

This will also generate the MIN_VERSION_foo macro for the current package, but that's probably OK.

23Skidoo added a commit that referenced this pull request Mar 19, 2016

Merge pull request #3235 from erikd/master
Add current pkg info to generated `cabal_macros.h` file

@23Skidoo 23Skidoo merged commit 3fb85c9 into haskell:master Mar 19, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Mar 19, 2016

Merged, thanks!

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Mar 19, 2016

Also cherry-picked into 1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment