Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a goal order parameter to the dependency solver #3510

Merged
merged 6 commits into from
Jul 1, 2016

Conversation

grayjay
Copy link
Collaborator

@grayjay grayjay commented Jun 26, 2016

This PR implements #3489. It isn't ready to be merged yet, because I need to finish updating the tests that are affected by goal order.

I wanted to make it available for review before finishing it, because it probably overlaps with #3502. The second commit exposes the solver's goal qualification types. I moved types like Q, QPN, and PP into a new module, D.Solver.Types.PackagePath, and renamed some of them. /cc @dcoutts

@dcoutts
Copy link
Contributor

dcoutts commented Jun 26, 2016

Second patch looks fine to me.

@23Skidoo
Copy link
Member

/cc @kosmikus

@grayjay
Copy link
Collaborator Author

grayjay commented Jun 26, 2016

Thanks! I made a separate PR with the second commit: #3511

@grayjay
Copy link
Collaborator Author

grayjay commented Jun 27, 2016

I rebased on top of #3511 and used the new parameter in the three unit tests that seemed most fragile.

/cc @edsko @kosmikus

@kosmikus
Copy link
Contributor

LGTM.

@dcoutts
Copy link
Contributor

dcoutts commented Jul 1, 2016

@23Skidoo since @grayjay and @kosmikus are happy with it then it's probably good to go.

@23Skidoo 23Skidoo merged commit 8f32ab4 into haskell:master Jul 1, 2016
@23Skidoo
Copy link
Member

23Skidoo commented Jul 1, 2016

Merged, thanks!

@grayjay
Copy link
Collaborator Author

grayjay commented Jul 3, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants