Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark template-haskell non-upgradable (again) #4185

Merged
merged 1 commit into from
Dec 22, 2016

Conversation

hvr
Copy link
Member

@hvr hvr commented Dec 21, 2016

65e9b88 made template-haskell non-upgradable

65ae95c made it upgradable again

...and this commit makes it non-upgradable again

While there may be a few cases when template-haskell can be
reinstalled, it's generally not advisable, and causes more harm than the
benefit in the few cases where we'd gain install-plan
flexibility (e.g. when only template-haskell's API is needed for
compile, but no actual TH evaluation takes place).

Closes #4098

65e9b88 made template-haskell non-upgradable

65ae95c made it upgradable again

...and this commit makes it non-upgradable again

While there may be a few cases when `template-haskell` can be
reinstalled, it's generally not advisable, and causes more harm than the
benefit in the few cases where we'd gain install-plan
flexibility (e.g. when only template-haskell's API is needed for
compile, but no actual TH evaluation takes place).

Closes haskell#4098
@mention-bot
Copy link

@hvr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kosmikus, @dcoutts and @grayjay to be potential reviewers.

@23Skidoo
Copy link
Member

OK. Do we want this backported to 1.24?

@hvr
Copy link
Member Author

hvr commented Dec 22, 2016

@23Skidoo probably; there is a slight risk that it may outlaw working install-plans (e.g. those which don't actually evaluate TH code using the reinstalled template-haskell lib), but it would reduce the risk of users being confused about the weird error messages they get when this causes errors due to GHC being confused.

So I'd suggest to backport this to the next 1.24 point rls of cabal-install

@23Skidoo 23Skidoo merged commit 87b650d into haskell:master Dec 22, 2016
@23Skidoo
Copy link
Member

Merged, thanks!

@23Skidoo
Copy link
Member

Also cherry-picked into 1.24 (141effc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants