Disable RPath usage on macOS #7076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interferes with dead_strip_dylib, and pollutes the load commands, which have a size limit in recent macOS versions. We now rely on GHC to construct the correct -rpath entries *after* the linking phase by inspecting the produced dynamic product and adding -rpaths for all non-dead-stripped referenced libraries. See https://gitlab.haskell.org/ghc/ghc/-/commit/4ff93292243888545da452ea4d4c1987f2343591 or ghc/ghc@4ff9329 Commissioned-by: Mercury Technologies, Inc. (mercury.com)
angerman
force-pushed
the
angerman/drop-rpath
branch
from
5ae413d
to
c250d38
Compare
phadej
suggested changes
Sep 18, 2020
phadej
reviewed
Sep 18, 2020
| -- well as being part of GHC 9.2 onwards. | ||
| -- | ||
| -- We know the GHC in question supports this if it knows about | ||
| -- `install_name_tool` or `otool`. |
There was a problem hiding this comment.
This suggests that there should some check of install_name_tool?
There was a problem hiding this comment.
Yes. Need to figure out how.
Do you have suggestions how to test this properly? Effectively we strip cabal from passing
Won't get this feature. Hence cabal should pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interferes with dead_strip_dylib, and pollutes the load commands,
which have a size limit in recent macOS versions. We now rely on GHC
to construct the correct -rpath entries after the linking phase by
inspecting the produced dynamic product and adding -rpaths for all
non-dead-stripped referenced libraries.
See https://gitlab.haskell.org/ghc/ghc/-/commit/4ff93292243888545da452ea4d4c1987f2343591
or ghc/ghc@4ff9329
Please include the following checklist in your PR:
changelog.ddirectory).Please also shortly describe how you tested your change. Bonus points for added tests!