Remove RPATH workaround #9164
Merged
Remove RPATH workaround #9164
+0
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabedini
force-pushed
the
remove-rpath-workaround
branch
from
0ae9d5d
to
4602958
Compare
geekosaur
approved these changes
Aug 11, 2023
|
Pinging @nomeata @angerman @phadej @Deltaspace0 you have been active on the issues around RPATH that @Mikolaj has identified above. Do you have anyfeedback about this change? |
angerman
approved these changes
Aug 14, 2023
|
Just waiting until the end of the week for more feedback, then I'll add the merge me label. |
andreabedini
added
merge me
mergify
bot
added
the
merge delay passed
Maybe 7 years ago it was relevant but it seems today it is not needed anymore.
Mikolaj
force-pushed
the
remove-rpath-workaround
branch
from
d6ca461
to
941d4de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe 7 years ago it was relevant but it seems today it is not needed anymore.
This workaround was not needed in my tests and I found some evidence it was not needed 10 years ago either.
This workaround prevents Cabal from building complete standalone foreign libraries on Linux, which the documentation says it is not supported but it indeed works (as long as you have a GHC bindist with -fPIC).
Let's see if the CI agrees with me☺️