New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions to the PR template for manual QA #8886
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There should be a link with "What QA notes are", or an example, or similar. Some contributors might be unaware! |
Kleidukos
force-pushed
the
8865-qa-instructions
branch
from
March 31, 2023 19:23
b261a0d
to
97617a7
Compare
Kleidukos
force-pushed
the
8865-qa-instructions
branch
from
March 31, 2023 19:24
97617a7
to
d8119e4
Compare
Kleidukos
commented
Mar 31, 2023
ffaf1
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent.
Kleidukos
added
attention: needs-review
type: testing
Issues about project test suites
labels
Mar 31, 2023
ulysses4ever
reviewed
Apr 5, 2023
ulysses4ever
reviewed
Apr 5, 2023
ulysses4ever
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terrific, thank you!
Kleidukos
force-pushed
the
8865-qa-instructions
branch
from
April 5, 2023 19:29
b7c31fd
to
5b9e5de
Compare
Kleidukos
added
merge me
Tell Mergify Bot to merge
squash+merge me
Tell Mergify Bot to squash-merge
and removed
attention: needs-review
merge me
Tell Mergify Bot to merge
labels
Apr 5, 2023
mergify
bot
added
the
merge delay passed
Applied (usually by Mergify) when PR approved and received no updates for 2 days
label
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merge delay passed
Applied (usually by Mergify) when PR approved and received no updates for 2 days
squash+merge me
Tell Mergify Bot to squash-merge
type: testing
Issues about project test suites
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds instructions for adding manual QA instructions to new PRs that relate to cabal-install when a behaviour is introduced or modified.
Relates to #8865