Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to the PR template for manual QA #8886

Merged
merged 6 commits into from Apr 7, 2023

Conversation

Kleidukos
Copy link
Member

This PR adds instructions for adding manual QA instructions to new PRs that relate to cabal-install when a behaviour is introduced or modified.

Relates to #8865

@ffaf1
Copy link
Collaborator

ffaf1 commented Mar 31, 2023

There should be a link with "What QA notes are", or an example, or similar. Some contributors might be unaware!

Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@Kleidukos Kleidukos added attention: needs-review type: testing Issues about project test suites labels Mar 31, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific, thank you!

@Kleidukos Kleidukos added merge me Tell Mergify Bot to merge squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review merge me Tell Mergify Bot to merge labels Apr 5, 2023
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 7, 2023
@mergify mergify bot merged commit 1f1beee into haskell:master Apr 7, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days squash+merge me Tell Mergify Bot to squash-merge type: testing Issues about project test suites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants