Warn early overwrite expanded #9506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Mikolaj
requested review from
andreabedini,
mpickering,
geekosaur and
ulysses4ever
geekosaur
approved these changes
Dec 9, 2023
ulysses4ever
approved these changes
Dec 10, 2023
|
I left couple more comments under the old PR, sorry... |
* Add symlinkableBinary * Extract installExesPrep * Add data InstallExe and data Symlink * Replace symlinkable with symlink taking InstallExe * Replace symlink/copy as symlink or copy * Improve a haddock, from check to try and stop * Get rid of duplication between install*Exes * Add InstallCfg * Drop the cfg prefix * Make errorMessage a where nested local * Add haddocks to InstallCheck
* Add project to avoid solver errors * SkipIfWindows for warn early overwrite tests * Windows does not natively include a touch command * Skip symlink install on windows * Add install by copy test and skip symlink install for Windows
philderbeast
force-pushed
the
warn-early-overwrite-expanded
branch
2 times, most recently
from
9327025
to
fef7145
Compare
As requested in review
As prompted to do so in review
philderbeast
force-pushed
the
warn-early-overwrite-expanded
branch
from
fef7145
to
729c659
Compare
|
Label |
mergify
bot
added
the
merge delay passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5993. This is the same as #9268 but with the refactoring introduced in earlier commits before the fix.
Bonus points for added automated tests!