Map/IntMap: Document the most common O(n²) performance mistake #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treeowl
requested changes
Jul 10, 2023
nh2
force-pushed
the
document-fromListWith-combination-function-performance
branch
from
2664751
to
6cf6aba
Compare
|
Please have another look -- I would like to merge it before any merge conflicts arise. |
|
Sorry this took so long. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the single most common performance mistake when dealing with
containers.I have seen professional Haskellers, get it wrong or wonder about it countless times, and the only hint in the entire module space on how the function
f :: a -> a -> ais applied is on the docs ofinsertWith, which is not where anybody looks when checking the docs of any of these functions.