Proposal process #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgibbard
reviewed
Oct 23, 2021
Co-authored-by: cgibbard <cgibbard@gmail.com>
|
Thanks for spotting that typo :D |
Merged
Bodigrim
reviewed
Oct 25, 2021
|
Looks good to me. I agree with Bodigrim's comments. |
Co-authored-by: Bodigrim <andrew.lelechenko@gmail.com>
Co-authored-by: Bodigrim <andrew.lelechenko@gmail.com>
Co-authored-by: Bodigrim <andrew.lelechenko@gmail.com>
|
Thanks again @Bodigrim, I've added points relevant to the suggestions you made. I'll let everyone read it over again before merging! |
gwils
approved these changes
Oct 27, 2021
Bodigrim
reviewed
Oct 27, 2021
cgibbard
approved these changes
Oct 27, 2021
chessai
reviewed
Oct 27, 2021
chessai
reviewed
Oct 27, 2021
chessai
reviewed
Oct 27, 2021
chessai
reviewed
Oct 27, 2021
|
Love the tone here, and the free-flowing approach to proposals that doesn't feel bogged down by processes. |
just so that we don't discourage *all* docs changes
|
alrighty, i think that's everything! @emilypi since you haven't reviewed yet I'll let you do that! |
Bodigrim
approved these changes
Oct 28, 2021
emilypi
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone!
I added the last paragraph saying stuff about how we ought to be held accountable. Not exactly sure what the best link to put in there is, though, so let me know before we merge!