Informative error message for insEdge
#16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented in haskell#14 , an irrefutable pattern exception is thrown when attempting to insert an edge from a vertex that does not exist in the graph, .e.g insEdge (0,1,"foo") (mkGraph [] []) The previous behaviour of fgl was: mkGraph *** Exception: Data/Graph/Inductive/Graph.hs:229:5-38: Irrefutable pattern failed for pattern (Just (pr, _, la, su), g') The new behaviour is: mkGraph *** Exception: insEdge: unable to add edge from non-existent vertex 0 closes haskell#14
robstewart57
referenced
this pull request
in robstewart57/fgl
Jun 5, 2015
As documented in haskell#14 , an irrefutable pattern exception is thrown when attempting to insert an edge from a vertex that does not exist in the graph, .e.g insEdge (0,1,"foo") (mkGraph [] []) The previous behaviour of fgl was: mkGraph *** Exception: Data/Graph/Inductive/Graph.hs:229:5-38: Irrefutable pattern failed for pattern (Just (pr, _, la, su), g') The new behaviour is: mkGraph *** Exception: insEdge: unable to add edge from non-existent vertex 0
|
Merged manually. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in #14 , an irrefutable pattern exception is
thrown when attempting to insert an edge from a vertex that does not
exist in the graph, .e.g
The previous behaviour of fgl was:
mkGraph *** Exception: Data/Graph/Inductive/Graph.hs:229:5-38: Irrefutable pattern failed for pattern (Just (pr, _, la, su), g')
The new behaviour is:
mkGraph *** Exception: insEdge: unable to add edge from non-existent vertex 0
closes #14