Add a bootstrap-haskell script, fixes #36 #40

hasufell · 2018-11-04T10:39:39Z

No description provided.

m-renaud · 2018-11-04T17:13:00Z

I added a PR for the script I had previously written (#41) for comparison.

m-renaud · 2018-11-29T03:24:32Z

Hey! Anything I can do to help move this along? It would be great to have this ready when cabal 3.0 is released so there's a good story for the whole toolchain :)

hasufell · 2018-12-01T06:13:26Z

@m-renaud please try the latest version

hasufell · 2018-12-01T16:53:07Z

travis is forever broken here and I cannot figure out how to fix it

m-renaud · 2018-12-01T18:08:36Z

@hasufell tried it out just now, works great other than the "wait for input not working".

I downloaded the script to a local file and ran cat bootstrap-haskell | sh and it printed the prompt to press enter to continue, but continued along with actually waiting for input.

If I change the script to be executable (chmod +x bootstrap-haskell) and then ./bootstrap-haskell it works as expected. It looks likeread has different behaviour if its piped into sh instead of being run as a script as part of a pipeline (see this SO answer).

So, it looks like our options are either:

Use the workaround provided there (3 commands, messier, -1 from me)
Don't prompt, just install.

My vote would be for (2), if they're on the ghcup site they already know what it does. At the bottom we could give instructions for how to uninstall ghcup (namely, rm -rf ~/.ghcup), or we could also provide a ghcup uninstall command which does the right thing. I think for an initial version just providing instructions would be sufficient.

Also, I noticed that the script runs _edo ghcup set which just prints the usage of the command at the bottom:

Done installing, run "ghci-8.4.4" or set up your current GHC via: ghcup set 8.4.4
ghcup set
ghcup-set
Set the currently active GHC to the specified version

USAGE:
    ghcup set [FLAGS] <VERSION>

FLAGS:
    -h, --help       Prints help information

ARGS:
    <VERSION>        E.g. "8.4.3" or "8.6.1"

DISCUSSION:
    Sets the the current GHC version by creating non-versioned
    symlinks for all ghc binaries of the specified version in
    "~/.ghcup/bin/<binary>".

Was that intentional?

m-renaud · 2018-12-01T18:18:42Z

.travis.yml

@@ -15,16 +15,18 @@ addons:
    - gcc
    - git
    - libgmp-dev
-    - libllvm5.0
+    # - libllvm5.0


Any reason why these and below are commented out?

Any reason why these and below are commented out?

Because we don't use llvm code generator.

Maybe I should have commented on the lines below, but llvm-5.0 and llvm-5.0-dev are both removed, and afaik at least one of those provides a linker in the environment. You mentioned in another comment that Travis is broken, I wouldn't be entirely surprised if this was why.

I doubt it. llvm is only used for llvm code generation. The linker is provided by binutils.

m-renaud · 2018-12-01T18:19:24Z

I noticed you commented out some of the llvm deps in the travis config, what's the rationale behind that? It looks like it may be the cause of the issue.

m-renaud · 2018-12-02T00:10:18Z

Also, I just realized that by running just ghcup set returns a status code of 1 meaning that cabal-install is never installed.

hasufell · 2018-12-02T12:56:06Z

Also, I noticed that the script runs _edo ghcup set which just prints the usage of the command at the bottom:

That's because you are upgrading to an older version while the script is running. See what the travis.sh does.

I noticed you commented out some of the llvm deps in the travis config, what's the rationale behind that? It looks like it may be the cause of the issue.

Why do you think that? It's gold linker messup afais and GHC just picks up whatever it wants.

Also, I just realized that by running just ghcup set returns a status code of 1 meaning that cabal-install is never installed.

See above, you're upgrading to an older version while running the script. Set BOOTSTRAP_HASKELL_NO_UPGRADE=1.

hasufell · 2018-12-02T12:57:32Z

If I change the script to be executable (chmod +x bootstrap-haskell) and then ./bootstrap-haskell it works as expected. It looks likeread has different behaviour if its piped into sh instead of being run as a script as part of a pipeline (see this SO answer).

Will look into it.

m-renaud · 2018-12-02T19:21:10Z

Sorry, I don't think I was very clear in my previous comment, either that or I didn't follow your response.

When I pipe the bootstrap-haskell script though sh it doesn't complete successfully. It installs ghc but then fails at the next step:

...
Done installing, run "ghci-8.4.4" or set up your current GHC via: ghcup set 8.4.4
ghcup set
ghcup-set
Set the currently active GHC to the specified version

USAGE:
    ghcup set [FLAGS] <VERSION>

FLAGS:
    -h, --help       Prints help information

ARGS:
    <VERSION>        E.g. "8.4.3" or "8.6.1"

DISCUSSION:
    Sets the the current GHC version by creating non-versioned
    symlinks for all ghc binaries of the specified version in
    "~/.ghcup/bin/<binary>".

$ echo $?
2

The bootstrap-haskell script has the line _edo ghcup set which is incorrect usage, causing the script to exit early and never run _edo ghcup install-cabal or any of the other commands below it.

Shouldn't it be _edo ghcup set 8.4.4?

m-renaud · 2018-12-02T19:25:53Z

ghcup


 FLAGS:
    -h, --help       Prints help information

 ARGS:
-    <VERSION>        E.g. \"8.4.3\" or \"8.6.1\"
+    [VERSION|TAG]    E.g. \"8.4.3\" or \"8.6.1\" or


Maybe use 8.6.2 as an example since 8.6.1 was a broken release?

m-renaud · 2018-12-02T20:16:36Z

bootstrap-haskell

+
+_edo ghcup install
+
+_edo ghcup set


Replacing this by the following results in the script finishing successfully:

recommendedGhcVer=`ghcup list -t ghc | grep recommended | cut -f2` _edo ghcup set $recommendedGhcVer

hasufell · 2018-12-03T02:34:37Z

The bootstrap-haskell script has the line _edo ghcup set which is incorrect usage, causing the script to exit early and never run _edo ghcup install-cabal or any of the other commands below it.

Shouldn't it be _edo ghcup set 8.4.4?

No, the line is correct, I already explained it: You're upgrading to an older version while running the script. Set BOOTSTRAP_HASKELL_NO_UPGRADE=1 (after you've copied the script from this PR). Also see the commits of this PR.

m-renaud · 2018-12-03T03:11:12Z

No, the line is correct...

Ah, yes you're right. I see where my confusion came from: I hadn't realized that there was a required change to ghcup in this PR to make ghcup set auto-discover the version to use if no arguments are passed. I had just pulled down a copy of the bootstrap script, not the updated ghcup so the ghcup that was being downloaded and used obviously didn't have this change so was erroring out. Sorry about the noise.

hasufell · 2018-12-03T03:24:16Z

to make ghcup set auto-discover the version to use if no arguments are passed

Yeah, I think it's a useful feature. Also removes the need to hack around and try to source ghcup.

hasufell · 2018-12-10T02:45:44Z

So, in order to merge this I would basically have to exclude this from the travis test...

m-renaud · 2018-12-10T03:35:21Z

I think it would be reasonable to exclude this from the Travis test initially and figure how to add it in as a follow-up.

hasufell · 2018-12-10T03:50:15Z

The only issue remaining was the read thing right?

m-renaud · 2018-12-10T04:29:52Z

Yup, I think a reasonable solution for the first version of the script is to just do it without asking.

hasufell · 2019-01-04T03:55:01Z

If I change the script to be executable (chmod +x bootstrap-haskell) and then ./bootstrap-haskell it works as expected. It looks likeread has different behaviour if its piped into sh instead of being run as a script as part of a pipeline (see this SO answer).

So, it looks like our options are either:
1. Use the workaround provided there (3 commands, messier, -1 from me)

2. Don't prompt, just install.

I explicitly read from /dev/tty now. This seems to work well. I'm not 100% sure how portable that is, but it seems to be part of posix: http://pubs.opengroup.org/onlinepubs/009696699/basedefs/xbd_chap10.html

If a GHC is already installed, we shouldn't treat it as an error.

hasufell force-pushed the bootstrap branch 11 times, most recently from cc9064c to 6a2847e Compare November 4, 2018 14:10

m-renaud mentioned this pull request Nov 4, 2018

Create get-ghcup.sh, fixes #36 #41

Closed

hasufell added this to the 0.0.7 milestone Nov 20, 2018

m-renaud mentioned this pull request Dec 1, 2018

Make downloads page as simple as possible haskell-infra/hl#221

Open

hasufell force-pushed the bootstrap branch from 6a2847e to 3afcc35 Compare December 1, 2018 06:11

hasufell force-pushed the bootstrap branch 2 times, most recently from 8c61516 to 2c7cd73 Compare December 1, 2018 06:48

m-renaud reviewed Dec 1, 2018

View reviewed changes

m-renaud reviewed Dec 2, 2018

View reviewed changes

m-renaud mentioned this pull request Dec 19, 2018

Create haskell.org/ghcup/ haskell-infra/hl#248

Closed

hasufell force-pushed the bootstrap branch from 2c7cd73 to 3d7e025 Compare January 4, 2019 03:53

hasufell force-pushed the bootstrap branch 2 times, most recently from 0b57187 to 1277427 Compare January 4, 2019 04:38

hasufell added 3 commits January 4, 2019 13:51

Make 'ghcup set' tag-aware

717a825

Tweak exit code for 'ghcup install'

4c548c1

If a GHC is already installed, we shouldn't treat it as an error.

Remove is_sourced functionality, it's not needed anymore

9cc652e

hasufell force-pushed the bootstrap branch from 1277427 to c7bcae2 Compare January 4, 2019 05:53

Add a bootstrap-haskell script, fixes #36

82c1636

hasufell force-pushed the bootstrap branch from c7bcae2 to 82c1636 Compare January 4, 2019 09:55

hasufell merged commit 82c1636 into master Jan 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a bootstrap-haskell script, fixes #36 #40

Add a bootstrap-haskell script, fixes #36 #40

hasufell commented Nov 4, 2018 •

edited

m-renaud commented Nov 4, 2018

m-renaud commented Nov 29, 2018

hasufell commented Dec 1, 2018

hasufell commented Dec 1, 2018

m-renaud commented Dec 1, 2018

m-renaud Dec 1, 2018

hasufell Dec 2, 2018

m-renaud Dec 5, 2018

hasufell Dec 5, 2018

m-renaud commented Dec 1, 2018 •

edited

m-renaud commented Dec 2, 2018

hasufell commented Dec 2, 2018 •

edited

hasufell commented Dec 2, 2018

m-renaud commented Dec 2, 2018

m-renaud Dec 2, 2018

m-renaud Dec 2, 2018

hasufell commented Dec 3, 2018 •

edited

m-renaud commented Dec 3, 2018

hasufell commented Dec 3, 2018

hasufell commented Dec 10, 2018

m-renaud commented Dec 10, 2018

hasufell commented Dec 10, 2018

m-renaud commented Dec 10, 2018

hasufell commented Jan 4, 2019

Add a bootstrap-haskell script, fixes #36 #40

Add a bootstrap-haskell script, fixes #36 #40

Conversation

hasufell commented Nov 4, 2018 • edited

m-renaud commented Nov 4, 2018

m-renaud commented Nov 29, 2018

hasufell commented Dec 1, 2018

hasufell commented Dec 1, 2018

m-renaud commented Dec 1, 2018

m-renaud Dec 1, 2018

Choose a reason for hiding this comment

hasufell Dec 2, 2018

Choose a reason for hiding this comment

m-renaud Dec 5, 2018

Choose a reason for hiding this comment

hasufell Dec 5, 2018

Choose a reason for hiding this comment

m-renaud commented Dec 1, 2018 • edited

m-renaud commented Dec 2, 2018

hasufell commented Dec 2, 2018 • edited

hasufell commented Dec 2, 2018

m-renaud commented Dec 2, 2018

m-renaud Dec 2, 2018

Choose a reason for hiding this comment

m-renaud Dec 2, 2018

Choose a reason for hiding this comment

hasufell commented Dec 3, 2018 • edited

m-renaud commented Dec 3, 2018

hasufell commented Dec 3, 2018

hasufell commented Dec 10, 2018

m-renaud commented Dec 10, 2018

hasufell commented Dec 10, 2018

m-renaud commented Dec 10, 2018

hasufell commented Jan 4, 2019

hasufell commented Nov 4, 2018 •

edited

m-renaud commented Dec 1, 2018 •

edited

hasufell commented Dec 2, 2018 •

edited

hasufell commented Dec 3, 2018 •

edited