Create get-ghcup.sh, fixes #36 #41
Conversation
This follows the style of the rustup installation script that has a friendly welcome message, tells you what the script is going to do, and then asks if you'd like to proceed. This is meant to be a one-command setup of everything you need to get started with Haskell.
| # not then add it. | ||
| if [ -z "`cat "$HOME/.bashrc" | grep 'source "$HOME/.ghcup/env"'`" ]; then | ||
| echo "Updating $HOME/.bashrc to source ghcup environment file..." | ||
| echo 'source "$HOME/.ghcup/env"' >> $HOME/.bashrc |
There was a problem hiding this comment.
Uh, no, never :)
Changing user configuration files like bashrc is something that I don't want to do at all. This is very intrusive and may not even work, depending on how the bashrc file is structured.
There was a problem hiding this comment.
Yeah I wasn't sold on this either, the rustup script does something similar, but adds it to .profile which is arguably the correct place. I used .bashrc to mirror the readme instructions but you're correct this could very well break things. It would be nice if system configuration was a bit more structured :)
There was a problem hiding this comment.
I think it would be ok if this is interactive and asks in CAPITAL LETTERS IF YOU REALLY WANT US TO APPEND TO YOUR BASHRC ;)
|
Thanks, the messages in this PR are better, but I think feature wise #40 is a bit more comprehensive, so maybe I'll improve the user facing messages. |
This follows the style of the rustup installation script that has a friendly welcome message, tells you what the script is going to do, and then asks if you'd like to proceed. This is meant to be a one-command setup of everything you need to get started with Haskell.
I already had this written so adding it for comparison to #40. Would still need to update README and clean a few things up. Let me know what you think!