-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FreeBSD download URLs #70
Conversation
cabal-install downloads are missing afais |
There is already one for 2.4.1.0, which I successfully used. |
You can try the following # @FUNCTION: emake
# @USAGE: [arguments]
# @DESCRIPTION:
# Wrapper around 'make', may call 'gmake' if it exists.
emake() {
# avoid re-checking for gmake
if [ -n "${MAKE}" ] ; then
edo ${MAKE} "$@"
else
if command_exists gmake ; then
MAKE=gmake
edo ${MAKE} "$@"
else
MAKE=make
edo ${MAKE} "$@"
fi
fi
} And then replace all our |
I've marked this "ready for review". Note that the binaries don't work very well on FreeBSD12 (which I'm running). @hvr is trying to find the relevant issue, which relates to ABI differences between FreeBSD 11 and 12 |
IIrc the ABI issues are due to https://lists.freebsd.org/pipermail/freebsd-fs/2017-April/024684.html which affects syscalls such as |
Perhaps I should mark these as |
That would enable us to merge the current PR I guess. Does ghcup detect the |
It does now! On FreeBSD 11, I built and ran tests of lens on all major ghc releases that ghcup supports. The tests all pass except for the doctests. For 8.0.2, I've put FreeBSD 9 or 10 or 11, because the release notes claim that build will work on those versions. For later versions I've been more conservative. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix edo "${MAKE}" "$@"
to edo ${MAKE} "$@"
By the way, I can smash this all into one or two commits if you'd prefer. |
This does not currently work because the Makefile it calls requires GNU make (ie. it does not work with BSD make). We can fix this by having FreeBSD call
gmake
instead ofmake
, but I haven't figured out how to do that yet (bash is not my specialty).So if anybody would like to do that or help me with it, we can get FreeBSD support happening!