Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow retroactively adding dependency on base-orphans #472

Closed
hvr opened this issue Jan 20, 2016 · 2 comments
Closed

Allow retroactively adding dependency on base-orphans #472

hvr opened this issue Jan 20, 2016 · 2 comments

Comments

@hvr
Copy link
Member

hvr commented Jan 20, 2016

(TODO: fill out description)
hvr added a commit that referenced this issue Jan 20, 2016
@hvr
Refactor dependency-edit-validation and address #472
7eb4e56 
The previous exception for `base` wasn't working properly anyway.

This refactoring also makes the error message more verbose in case of
rejections.
@hvr hvr changed the title Allow retroactively adding dependency on base Allow retroactively adding dependency on base-orphans Jan 20, 2016
@dcoutts
Copy link
Contributor

dcoutts commented May 15, 2016

@hvr you did this didn't you?

@hvr
Copy link
Member Author

hvr commented Jun 10, 2016

@dcoutts yes, it's done, and it works as designed

@hvr hvr closed this as completed Jun 10, 2016
@hvr hvr mentioned this issue Jun 10, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hvr @dcoutts